Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/fsx_lustre_file_system - Add copy_tags_to_backups #15687

Merged
merged 7 commits into from
Oct 21, 2020
Merged

r/fsx_lustre_file_system - Add copy_tags_to_backups #15687

merged 7 commits into from
Oct 21, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 16, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Supersedes #15262

Release note for CHANGELOG:

resource_aws_ fsx_lustre_file_system - add support for `copy_tags_to_backups`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
--- PASS: TestAccAWSFsxLustreFileSystem_basic (592.31s)
--- PASS: TestAccAWSFsxLustreFileSystem_copyTagsToBackups (565.11s)
...

@DrFaust92 DrFaust92 requested a review from a team October 16, 2020 18:32
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Oct 16, 2020
@DrFaust92 DrFaust92 changed the title [WIP]r/fsx_lustre_file_system - Add copy_tags_to_backups r/fsx_lustre_file_system - Add copy_tags_to_backups Oct 16, 2020
@mtpdt mtpdt mentioned this pull request Oct 21, 2020
Closed
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 21, 2020
ewbankkit
ewbankkit approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxLustreFileSystem_copyTagsToBackups\|TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_copyTagsToBackups\|TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== PAUSE TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_copyTagsToBackups
--- PASS: TestAccAWSFsxLustreFileSystem_copyTagsToBackups (560.80s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (587.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	587.251s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSFsxLustreFileSystem_copyTagsToBackups\|TestAccAWSFsxLustreFileSystem_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_copyTagsToBackups\|TestAccAWSFsxLustreFileSystem_basic -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== PAUSE TestAccAWSFsxLustreFileSystem_copyTagsToBackups
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_copyTagsToBackups
--- PASS: TestAccAWSFsxLustreFileSystem_copyTagsToBackups (530.61s)
--- PASS: TestAccAWSFsxLustreFileSystem_basic (593.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	594.998s

@breathingdust breathingdust added this to the v3.12.0 milestone Oct 21, 2020
@breathingdust breathingdust merged commit a7beedd into hashicorp:master Oct 21, 2020
breathingdust added a commit that referenced this pull request Oct 21, 2020
@breathingdust
Update CHANGELOG.md for #15687
c2532b6
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2020
@DrFaust92 DrFaust92 deleted the fsx_lustre_copy_tags branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DrFaust92 @breathingdust @ewbankkit @mtpdt