Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the efs_mount_target creation timeout to 30 minutes #15293

Merged

Conversation

shuheiktgw
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15278

Release note for CHANGELOG:

None

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEFSMountTarget_*'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSMountTarget_* -timeout 120m
=== RUN   TestAccAWSEFSMountTarget_basic
=== PAUSE TestAccAWSEFSMountTarget_basic
=== RUN   TestAccAWSEFSMountTarget_disappears
=== PAUSE TestAccAWSEFSMountTarget_disappears
=== RUN   TestAccAWSEFSMountTarget_IpAddress
=== PAUSE TestAccAWSEFSMountTarget_IpAddress
=== RUN   TestAccAWSEFSMountTarget_IpAddress_EmptyString
=== PAUSE TestAccAWSEFSMountTarget_IpAddress_EmptyString
=== CONT  TestAccAWSEFSMountTarget_basic
=== CONT  TestAccAWSEFSMountTarget_IpAddress
=== CONT  TestAccAWSEFSMountTarget_IpAddress_EmptyString
=== CONT  TestAccAWSEFSMountTarget_disappears
    TestAccAWSEFSMountTarget_disappears: resource_aws_efs_mount_target_test.go:138: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSEFSMountTarget_IpAddress (159.13s)
--- PASS: TestAccAWSEFSMountTarget_disappears (159.33s)
--- PASS: TestAccAWSEFSMountTarget_IpAddress_EmptyString (164.62s)
--- PASS: TestAccAWSEFSMountTarget_basic (275.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	277.418s

Updated the timeout from 10 minutes to 30minutes. Thank you for your review!

@shuheiktgw shuheiktgw requested a review from a team September 22, 2020 23:18
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/efs Issues and PRs that pertain to the efs service. needs-triage Waiting for first response or review from a maintainer. labels Sep 22, 2020
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. enhancement Requests to existing resources that expand the functionality or scope. labels Sep 24, 2020
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shuheiktgw, nice work!

Output of acceptance tests:

--- PASS: TestResourceAWSEFSMountTarget_hasEmptyMountTargets (0.00s)
--- PASS: TestAccAWSEFSMountTarget_disappears (127.52s)
--- PASS: TestAccAWSEFSMountTarget_IpAddress_EmptyString (129.46s)
--- PASS: TestAccAWSEFSMountTarget_IpAddress (134.83s)
--- PASS: TestAccAWSEFSMountTarget_basic (224.81s)

@anGie44 anGie44 added this to the v3.8.0 milestone Sep 24, 2020
@anGie44 anGie44 merged commit 5e53f7b into hashicorp:master Sep 24, 2020
anGie44 added a commit that referenced this pull request Sep 24, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 3.8.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/efs Issues and PRs that pertain to the efs service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_efs_mount_target takes longer than 10 minutes to deploy
2 participants