fsx_lustre_file_system - add auto_import_policy argument

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14406

Release note for CHANGELOG:

resoruce_aws_fsx_lustre_file_system - add `auto_import_policy`  argument

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSFsxLustreFileSystem_'
--- PASS: TestAccAWSFsxLustreFileSystem_basic (596.06s)
--- PASS: TestAccAWSFsxLustreFileSystem_ExportPath (1396.45s)
--- PASS: TestAccAWSFsxLustreFileSystem_autoImportPolicy (1373.40s)

[bflad]

Should this default to NONE to match the API and enable drift detection when it is unconfigured?

Suggested change

	Computed: true,
	Default: fsx.AutoImportPolicyTypeNone,

[DrFaust92]

I tried to play to play with this but wasn't able to find a combination other than the one in the PR to maked this work.

[DrFaust92]

If set to default it will try to set this and fail as import/export params are required with it. Let me try something different with this. (I'll at least at requiredwith for import export for this param)

…

On Mon, Sep 21, 2020, 15:58 Brian Flad ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In aws/resource_aws_fsx_lustre_file_system.go <#15231 (comment)> : > @@ -137,6 +133,12 @@ func resourceAwsFsxLustreFileSystem() *schema.Resource { Computed: true, ValidateFunc: validation.IntBetween(0, 35), }, + "auto_import_policy": { + Type: schema.TypeString, + Optional: true, + Computed: true, Should this default to NONE to match the API <https://docs.aws.amazon.com/fsx/latest/APIReference/API_CreateFileSystemLustreConfiguration.html#FSx-Type-CreateFileSystemLustreConfiguration-AutoImportPolicy> and enable drift detection when it is unconfigured? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#15231 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIA2W7SSEZGYOQWMTQPAYQLSG5EWRANCNFSM4RTAQETQ> .

[DrFaust92]

Rebased

[ewbankkit]

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_autoImportPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_autoImportPolicy -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== PAUSE TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_autoImportPolicy
--- PASS: TestAccAWSFsxLustreFileSystem_basic (585.18s)
--- PASS: TestAccAWSFsxLustreFileSystem_autoImportPolicy (1196.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1196.389s

[breathingdust]

Hey @DrFaust92

Getting consistent test failures on this one, can you take a look?

make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_autoImportPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_autoImportPolicy -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_autoImportPolicy
    resource_aws_fsx_lustre_file_system_test.go:75: Check 19/19 error: aws_fsx_lustre_file_system.test: Attribute 'auto_import_policy' expected "NONE", got ""
--- FAIL: TestAccAWSFsxLustreFileSystem_basic (483.51s)

[DrFaust92]

@breathingdust mistake on my part during the rebase. basic test should not check this. its computed only when s3 export is set.

[breathingdust]

Thanks @DrFaust92, looking good now. 🚀

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_autoImportPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSFsxLustreFileSystem_basic\|TestAccAWSFsxLustreFileSystem_autoImportPolicy -timeout 120m
=== RUN   TestAccAWSFsxLustreFileSystem_basic
=== PAUSE TestAccAWSFsxLustreFileSystem_basic
=== RUN   TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== PAUSE TestAccAWSFsxLustreFileSystem_autoImportPolicy
=== CONT  TestAccAWSFsxLustreFileSystem_basic
=== CONT  TestAccAWSFsxLustreFileSystem_autoImportPolicy
--- PASS: TestAccAWSFsxLustreFileSystem_basic (642.49s)
--- PASS: TestAccAWSFsxLustreFileSystem_autoImportPolicy (1281.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1283.173s

[ghost]

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!