f/Support ApplyOnlyAtCronInterval for aws_ssm_association #15038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
needs-triage
ghost
added
the
tests
nikhil-goenka
changed the title
|
Is there any word on this getting merged? We're currently waiting for it as we need to apply a bunch of aws_ssm_association resources but don't want them all immediately firing when we do. |
bflad
added
enhancement
bflad
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
After splitting out the tests, looks good, thank you @nikhil-goenka 🚀
Output from acceptance testing in AWS Commercial:
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (26.48s)
--- PASS: TestAccAWSSSMAssociation_rateControl (36.32s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (39.12s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (39.44s)
--- PASS: TestAccAWSSSMAssociation_withParameters (41.73s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (41.97s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (49.30s)
--- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (53.28s)
--- PASS: TestAccAWSSSMAssociation_withTargets (57.36s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (57.49s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.00s)
--- PASS: TestAccAWSSSMAssociation_basic (98.52s)
--- PASS: TestAccAWSSSMAssociation_disappears (116.82s)
Output from acceptance testing in AWS GovCloud (US):
--- PASS: TestAccAWSSSMAssociation_withDocumentVersion (38.37s)
--- PASS: TestAccAWSSSMAssociation_withParameters (49.05s)
--- PASS: TestAccAWSSSMAssociation_rateControl (49.73s)
--- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (52.95s)
--- PASS: TestAccAWSSSMAssociation_withAssociationName (52.95s)
--- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (56.16s)
--- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (63.14s)
--- PASS: TestAccAWSSSMAssociation_withScheduleExpression (63.99s)
--- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (64.88s)
--- PASS: TestAccAWSSSMAssociation_withTargets (71.86s)
--- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.33s)
--- PASS: TestAccAWSSSMAssociation_basic (112.52s)
--- PASS: TestAccAWSSSMAssociation_disappears (119.66s)
| @@ -958,6 +958,7 @@ DOC | |||
| resource "aws_ssm_association" "test" { | |||
| name = aws_ssm_document.test.name | |||
| schedule_expression = "cron(0 16 ? * TUE *)" | |||
| apply_only_at_cron_interval = true | |||
There was a problem hiding this comment.
To ensure we are not introducing any regressions, going to split this new argument into its own testing on merge.
bflad
added a commit
that referenced
this pull request
Feb 12, 2021
…d add CHANGELOG entry for #15038 Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSSSMAssociation_withDocumentVersion (26.48s) --- PASS: TestAccAWSSSMAssociation_rateControl (36.32s) --- PASS: TestAccAWSSSMAssociation_withScheduleExpression (39.12s) --- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (39.44s) --- PASS: TestAccAWSSSMAssociation_withParameters (41.73s) --- PASS: TestAccAWSSSMAssociation_withAssociationName (41.97s) --- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (49.30s) --- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (53.28s) --- PASS: TestAccAWSSSMAssociation_withTargets (57.36s) --- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (57.49s) --- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.00s) --- PASS: TestAccAWSSSMAssociation_basic (98.52s) --- PASS: TestAccAWSSSMAssociation_disappears (116.82s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSSSMAssociation_withDocumentVersion (38.37s) --- PASS: TestAccAWSSSMAssociation_withParameters (49.05s) --- PASS: TestAccAWSSSMAssociation_rateControl (49.73s) --- PASS: TestAccAWSSSMAssociation_ApplyOnlyAtCronInterval (52.95s) --- PASS: TestAccAWSSSMAssociation_withAssociationName (52.95s) --- PASS: TestAccAWSSSMAssociation_withComplianceSeverity (56.16s) --- PASS: TestAccAWSSSMAssociation_withAssociationNameAndScheduleExpression (63.14s) --- PASS: TestAccAWSSSMAssociation_withScheduleExpression (63.99s) --- PASS: TestAccAWSSSMAssociation_withAutomationTargetParamName (64.88s) --- PASS: TestAccAWSSSMAssociation_withTargets (71.86s) --- PASS: TestAccAWSSSMAssociation_withOutputLocation (87.33s) --- PASS: TestAccAWSSSMAssociation_basic (112.52s) --- PASS: TestAccAWSSSMAssociation_disappears (119.66s) ```
|
This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #15034
Release note for CHANGELOG:
Output from acceptance testing: