Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceptance test preCheck for Lex in GovCloud #14893

Closed
gdavison opened this issue Aug 28, 2020 · 2 comments · Fixed by #15588
Closed

Add acceptance test preCheck for Lex in GovCloud #14893

gdavison opened this issue Aug 28, 2020 · 2 comments · Fixed by #15588
Assignees
@gdavison
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/lexmodels Issues and PRs that pertain to the lexmodels service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
v3.12.0

Comments

@gdavison
Copy link
Contributor

gdavison commented Aug 28, 2020 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

#8916 and other PRs add Lex resources to the AWS provider. Lex is not supported in GovCloud. We need to add a preCheck function to prevent the acceptance tests from running in GovCloud

Affected Resources

  • aws_lex_*

References
@gdavison gdavison added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 28, 2020
@ghost ghost added the service/lexmodels Issues and PRs that pertain to the lexmodels service. label Aug 28, 2020
@gdavison gdavison self-assigned this Aug 28, 2020
@bflad bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. partition/aws-us-gov Pertains to the aws-us-gov partition. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Aug 31, 2020
@YakDriver YakDriver mentioned this issue Oct 12, 2020
Merged
@breathingdust breathingdust added this to the v3.12.0 milestone Oct 15, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gdavison gdavison

Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/lexmodels Issues and PRs that pertain to the lexmodels service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging a pull request may close this issue.

tests/provider: Add precheck (Lex) hashicorp/terraform-provider-aws
3 participants
@bflad @breathingdust @gdavison