Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/codeartifact_repository - new resource #14429

Merged

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13714

Release note for CHANGELOG:

resource_aws_codeartifact_repository - add new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeArtifactRepository_'
--- PASS: TestAccAWSCodeArtifactRepository_basic (206.26s)
--- PASS: TestAccAWSCodeArtifactRepository_description (247.95s)
--- PASS: TestAccAWSCodeArtifactRepository_upstreams (561.75s)
--- PASS: TestAccAWSCodeArtifactRepository_disappears (174.06s)

@DrFaust92 DrFaust92 requested a review from a team July 31, 2020 13:57
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 31, 2020
@DrFaust92 DrFaust92 changed the title r/codeartifact_repository - new resource [WIP]r/codeartifact_repository - new resource Jul 31, 2020
@larstobi
Copy link
Contributor

@DrFaust92 Thanks for this! Is there any progress on the PR? 👍 :-)

@DrFaust92 DrFaust92 changed the title [WIP]r/codeartifact_repository - new resource r/codeartifact_repository - new resource Sep 30, 2020
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Sep 30, 2020
doc changes

Co-authored-by: Kit Ewbank <[email protected]>
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactRepository_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN   TestAccAWSCodeArtifactRepository_owner
=== PAUSE TestAccAWSCodeArtifactRepository_owner
=== RUN   TestAccAWSCodeArtifactRepository_description
=== PAUSE TestAccAWSCodeArtifactRepository_description
=== RUN   TestAccAWSCodeArtifactRepository_upstreams
=== PAUSE TestAccAWSCodeArtifactRepository_upstreams
=== RUN   TestAccAWSCodeArtifactRepository_disappears
=== PAUSE TestAccAWSCodeArtifactRepository_disappears
=== CONT  TestAccAWSCodeArtifactRepository_owner
=== CONT  TestAccAWSCodeArtifactRepository_upstreams
=== CONT  TestAccAWSCodeArtifactRepository_disappears
=== CONT  TestAccAWSCodeArtifactRepository_basic
=== CONT  TestAccAWSCodeArtifactRepository_description
=== CONT  TestAccAWSCodeArtifactRepository_disappears
    resource_aws_codeartifact_repository_test.go:214: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactRepository_disappears (31.82s)
--- PASS: TestAccAWSCodeArtifactRepository_owner (35.02s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (35.28s)
--- PASS: TestAccAWSCodeArtifactRepository_description (51.38s)
--- PASS: TestAccAWSCodeArtifactRepository_upstreams (71.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	71.805s

@DrFaust92
Copy link
Collaborator Author

resolved provider conflict

@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactRepository_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactRepository_basic
=== PAUSE TestAccAWSCodeArtifactRepository_basic
=== RUN   TestAccAWSCodeArtifactRepository_owner
=== PAUSE TestAccAWSCodeArtifactRepository_owner
=== RUN   TestAccAWSCodeArtifactRepository_description
=== PAUSE TestAccAWSCodeArtifactRepository_description
=== RUN   TestAccAWSCodeArtifactRepository_upstreams
=== PAUSE TestAccAWSCodeArtifactRepository_upstreams
=== RUN   TestAccAWSCodeArtifactRepository_disappears
=== PAUSE TestAccAWSCodeArtifactRepository_disappears
=== CONT  TestAccAWSCodeArtifactRepository_basic
=== CONT  TestAccAWSCodeArtifactRepository_upstreams
=== CONT  TestAccAWSCodeArtifactRepository_description
=== CONT  TestAccAWSCodeArtifactRepository_owner
=== CONT  TestAccAWSCodeArtifactRepository_disappears
    resource_aws_codeartifact_repository_test.go:214: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactRepository_disappears (16.94s)
--- PASS: TestAccAWSCodeArtifactRepository_basic (18.52s)
--- PASS: TestAccAWSCodeArtifactRepository_owner (19.41s)
--- PASS: TestAccAWSCodeArtifactRepository_description (31.34s)
--- PASS: TestAccAWSCodeArtifactRepository_upstreams (46.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	48.605s

@breathingdust breathingdust added this to the v3.9.0 milestone Oct 1, 2020
@breathingdust breathingdust merged commit a4c2fa1 into hashicorp:master Oct 1, 2020
breathingdust added a commit that referenced this pull request Oct 1, 2020
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/codeartifact Issues and PRs that pertain to the codeartifact service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants