Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_notebook_instance: Root access to Sagemaker notebook instance #14184

Merged
merged 2 commits into from
Sep 24, 2020
Merged

r/sagemaker_notebook_instance: Root access to Sagemaker notebook instance #14184

merged 2 commits into from
Sep 24, 2020

Conversation

cicdguy
Copy link
Contributor

@cicdguy cicdguy commented Jul 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #NA

Release note for CHANGELOG:

Ability to configure root access for Sagemaker notebook instances

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_root_access'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_root_access -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (652.27s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	653.837s

@cicdguy cicdguy requested a review from a team July 15, 2020 15:09
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jul 15, 2020
@cicdguy cicdguy changed the title Feature: Root access to Sagemaker notebook instance r/sagemaker_notebook_instance: Root access to Sagemaker notebook instance Jul 15, 2020
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 4, 2020
DrFaust92
DrFaust92 suggested changes Aug 23, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, small change request.

aws/resource_aws_sagemaker_notebook_instance.go Outdated
ForceNew: true,
Default: sagemaker.RootAccessEnabled,
ValidateFunc: validation.StringInSlice([]string{
sagemaker.RootAccessDisabled,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, can you change this to sagemaker.RootAccess_Values()

aws/resource_aws_sagemaker_notebook_instance_test.go Outdated
return fmt.Sprintf(`
resource "aws_sagemaker_notebook_instance" "foo" {
name = %[1]q
role_arn = "${aws_iam_role.foo.arn}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tf12 syntax

aws/resource_aws_sagemaker_notebook_instance_test.go Outdated
resource "aws_iam_role" "foo" {
name = %[1]q
path = "/"
assume_role_policy = "${data.aws_iam_policy_document.assume_role.json}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@cicdguy cicdguy requested review from DrFaust92 and removed request for a team August 24, 2020 17:50
DrFaust92
DrFaust92 approved these changes Aug 25, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (699.92s)

@cicdguy
Copy link
Contributor Author

cicdguy commented Aug 31, 2020

@DrFaust92 - Is this good to merge? We are eagerly anticipating this being available in a near future release.

ewbankkit
ewbankkit approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_root_access\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_root_access\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (305.93s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (625.81s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	625.849s

@breathingdust
Copy link
Member

LGTM! 🚀 Thanks @dinakar29

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_root_access\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_root_access\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (332.52s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (671.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	673.305s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_root_access\|TestAccAWSSagemakerNotebookInstance_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_root_access\|TestAccAWSSagemakerNotebookInstance_basic -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (297.88s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (693.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	694.530s

@breathingdust breathingdust added this to the v3.9.0 milestone Sep 24, 2020
@breathingdust breathingdust merged commit f9520e7 into hashicorp:master Sep 24, 2020
breathingdust added a commit that referenced this pull request Sep 24, 2020
@breathingdust
Update CHANGELOG.md for #14184
122aec7
@cicdguy cicdguy deleted the feature/sagemaker-notebook-instance-root-access branch September 25, 2020 17:02
@ghost
Copy link

ghost commented Oct 2, 2020

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cicdguy @breathingdust @ewbankkit @DrFaust92