Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: New versions of the provider can only be automatically installed on Terraform 0.12 and later #14143

Merged
merged 2 commits into from
Jul 14, 2020
Merged

provider: New versions of the provider can only be automatically installed on Terraform 0.12 and later #14143

merged 2 commits into from
Jul 14, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 10, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #13781
Reference: hashicorp/terraform-provider-azurerm#6323

Release note for CHANGELOG:

* provider: New versions of the provider can only be automatically installed on Terraform 0.12 and later

Automates the protocol 5 only setting on release.

Output from acceptance testing: N/A

@bflad
provider: Add .tfproto5 file for releases
d331435 
Reference: hashicorp/terraform-provider-azurerm#6323

Automates the protocol 5 only setting on release.
@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. provider Pertains to the provider itself, rather than any interaction with AWS. labels Jul 10, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 10, 2020
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Jul 10, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Jul 10, 2020
@bflad bflad changed the title provider: Add .tfproto5 file for releases provider: New versions of the provider can only be automatically installed on Terraform 0.12 and later Jul 10, 2020
@bflad bflad marked this pull request as ready for review July 10, 2020 20:50
@bflad bflad requested a review from a team July 10, 2020 20:50
anGie44
anGie44 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bflad bflad merged commit cb4b991 into master Jul 14, 2020
@bflad bflad deleted the td-tfproto5 branch July 14, 2020 21:57
bflad added a commit that referenced this pull request Jul 14, 2020
@bflad
Update CHANGELOG for #14143
3e5f930
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @anGie44