r/codeartifact_domain - new resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13714

Release note for CHANGELOG:

resource_aws_codeartifact_domain - new resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
--- PASS: TestAccAWSCodeArtifactDomain_basic (55.00s)
--- PASS: TestAccAWSCodeArtifactDomain_disappears (57.10s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
--- PASS: TestAccAWSCodeArtifactDomain_disappears (26.17s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (29.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.481s

[DrFaust92]

@ewbankkit, added the changes from review. Thanks as always!

[ewbankkit]

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
--- PASS: TestAccAWSCodeArtifactDomain_disappears (14.42s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (16.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	16.790s

[DrFaust92]

made some changes to better handle cross account resources as the api is account aware in its operations.

[ewbankkit]

Re-verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
--- PASS: TestAccAWSCodeArtifactDomain_disappears (14.30s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (15.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	15.975s

[bf-sodle]

Is there a timeline for merging this and the other CodeArtifact resource commits? Would be very nice to have this support available for a project.

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
    resource_aws_codeartifact_domain_test.go:104: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomain_disappears (19.32s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (21.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	21.739s

[breathingdust]

LGTM! 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAWSCodeArtifactDomain_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCodeArtifactDomain_ -timeout 120m
=== RUN   TestAccAWSCodeArtifactDomain_basic
=== PAUSE TestAccAWSCodeArtifactDomain_basic
=== RUN   TestAccAWSCodeArtifactDomain_disappears
=== PAUSE TestAccAWSCodeArtifactDomain_disappears
=== CONT  TestAccAWSCodeArtifactDomain_basic
=== CONT  TestAccAWSCodeArtifactDomain_disappears
    resource_aws_codeartifact_domain_test.go:104: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSCodeArtifactDomain_disappears (14.57s)
--- PASS: TestAccAWSCodeArtifactDomain_basic (16.75s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.398s

[ghost]

This has been released in version 3.9.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!