r/glacier_vault: fix policy diff + read after create + refactor tests

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12619 (possibly)
Relates #13826

Release note for CHANGELOG:

resource_aws_glacier_vault: remove from state when vault does not exist.
resource_aws_glacier_vault: add plan time validation to `sns_topic` in the `notification` block.
resource_aws_glacier_vault: add plan time validation to `events` in the `notification` block.
resource_aws_glacier_vault: fix diff for `access_policy`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlacierVault_'
--- PASS: TestAccAWSGlacierVault_basic (51.11s)
--- PASS: TestAccAWSGlacierVault_tags (145.51s)
--- PASS: TestAccAWSGlacierVault_disappears (32.80s)
--- PASS: TestAccAWSGlacierVault_notification (134.42s)
--- PASS: TestAccAWSGlacierVault_policy (79.08s)

[DrFaust92]

rebased + retested

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlacierVault_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSGlacierVault_ -timeout 120m
=== RUN   TestAccAWSGlacierVault_basic
=== PAUSE TestAccAWSGlacierVault_basic
=== RUN   TestAccAWSGlacierVault_notification
=== PAUSE TestAccAWSGlacierVault_notification
=== RUN   TestAccAWSGlacierVault_policy
=== PAUSE TestAccAWSGlacierVault_policy
=== RUN   TestAccAWSGlacierVault_tags
=== PAUSE TestAccAWSGlacierVault_tags
=== RUN   TestAccAWSGlacierVault_disappears
=== PAUSE TestAccAWSGlacierVault_disappears
=== CONT  TestAccAWSGlacierVault_basic
=== CONT  TestAccAWSGlacierVault_tags
=== CONT  TestAccAWSGlacierVault_disappears
=== CONT  TestAccAWSGlacierVault_policy
=== CONT  TestAccAWSGlacierVault_notification
--- PASS: TestAccAWSGlacierVault_disappears (19.35s)
--- PASS: TestAccAWSGlacierVault_basic (28.48s)
--- PASS: TestAccAWSGlacierVault_policy (31.39s)
--- PASS: TestAccAWSGlacierVault_tags (66.01s)
--- PASS: TestAccAWSGlacierVault_notification (71.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	71.875s

[DrFaust92]

Refactored:

--- PASS: TestAccAWSGlacierVault_notification (152.71s)
--- PASS: TestAccAWSGlacierVault_policy (135.11s)
--- PASS: TestAccAWSGlacierVault_tags (133.06s)
--- PASS: TestAccAWSGlacierVault_disappears (41.30s)

[ewbankkit]

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlacierVault_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlacierVault_ -timeout 120m
=== RUN   TestAccAWSGlacierVault_basic
=== PAUSE TestAccAWSGlacierVault_basic
=== RUN   TestAccAWSGlacierVault_notification
=== PAUSE TestAccAWSGlacierVault_notification
=== RUN   TestAccAWSGlacierVault_policy
=== PAUSE TestAccAWSGlacierVault_policy
=== RUN   TestAccAWSGlacierVault_tags
=== PAUSE TestAccAWSGlacierVault_tags
=== RUN   TestAccAWSGlacierVault_disappears
=== PAUSE TestAccAWSGlacierVault_disappears
=== CONT  TestAccAWSGlacierVault_basic
=== CONT  TestAccAWSGlacierVault_tags
=== CONT  TestAccAWSGlacierVault_policy
=== CONT  TestAccAWSGlacierVault_notification
=== CONT  TestAccAWSGlacierVault_disappears
    resource_aws_glacier_vault_test.go:246: [INFO] Got non-empty plan, as expected
--- PASS: TestAccAWSGlacierVault_disappears (19.78s)
--- PASS: TestAccAWSGlacierVault_basic (27.42s)
2020/08/28 09:28:51 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSGlacierVault_tags (59.22s)
--- PASS: TestAccAWSGlacierVault_policy (60.41s)
--- PASS: TestAccAWSGlacierVault_notification (64.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	64.957s

[bflad]

Looks good to me, thank you, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSGlacierVault_disappears (12.48s)
--- PASS: TestAccAWSGlacierVault_basic (17.66s)
--- PASS: TestAccAWSGlacierVault_policy (41.22s)
--- PASS: TestAccAWSGlacierVault_tags (43.39s)
--- PASS: TestAccAWSGlacierVault_notification (46.12s)

[bflad]

Appease newer static analysis

[ghost]

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!