r/lambda_event_source_mapping - allow zero value for maximum_retry_attempts

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12448

Release note for CHANGELOG:

resource_aws_lambda_event_source_mapping - allow zero value for `maximum_retry_attempts`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero'
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero (148.92s)

[ewbankkit]

Validated acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero
=== PAUSE TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero
=== CONT  TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero (105.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	105.326s

[ZachTB123]

Any updates on this?

[chipzzz]

Also experiencing this in
v0.12.7 terraform
version = "2.51.0" AWS provider

[ewbankkit]

LGTM.
Verified new acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero -timeout 120m
=== RUN   TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero
=== PAUSE TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero
=== CONT  TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero (103.37s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	103.418s

[anGie44]

LGTM 👍

Output of acceptance tests:

--- PASS: TestAccAWSLambdaEventSourceMapping_BatchWindow (71.21s)
--- PASS: TestAccAWSLambdaEventSourceMapping_BisectBatch (68.57s)
--- PASS: TestAccAWSLambdaEventSourceMapping_KinesisDestinationConfig (61.56s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRecordAgeInSeconds (71.71s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttempts (59.31s)
--- PASS: TestAccAWSLambdaEventSourceMapping_MaximumRetryAttemptsZero (67.26s)
--- PASS: TestAccAWSLambdaEventSourceMapping_ParallelizationFactor (70.05s)
--- PASS: TestAccAWSLambdaEventSourceMapping_StartingPositionTimestamp (78.60s)
--- PASS: TestAccAWSLambdaEventSourceMapping_changesInEnabledAreDetected (157.49s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_basic (75.16s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_disappears (53.37s)
--- PASS: TestAccAWSLambdaEventSourceMapping_kinesis_removeBatchSize (62.49s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqsDisappears (153.76s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_basic (144.63s)
--- PASS: TestAccAWSLambdaEventSourceMapping_sqs_withFunctionName (46.83s)

[ghost]

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!