r/aws_cognito_user_pool - add support for account recovery setting

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11220
Relates #13826

Release note for CHANGELOG:

resouce_aws_cognito_user_pool: add support for account recovery setting

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPool_'
--- PASS: TestAccAWSCognitoUserPool_basic (48.59s)
--- PASS: TestAccAWSCognitoUserPool_recovery (114.12s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfiguration (103.63s)
--- PASS: TestAccAWSCognitoUserPool_withAdminCreateUserConfigurationAndPasswordPolicy (47.56s)
--- PASS: TestAccAWSCognitoUserPool_withDeviceConfiguration (78.45s)
--- PASS: TestAccAWSCognitoUserPool_withEmailVerificationMessage (85.15s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfiguration (147.53s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationAndSoftwareTokenMfaConfiguration (129.68s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SmsConfigurationToSoftwareTokenMfaConfiguration (91.63s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfiguration (108.50s)
--- PASS: TestAccAWSCognitoUserPool_MfaConfiguration_SoftwareTokenMfaConfigurationToSmsConfiguration (101.67s)
--- PASS: TestAccAWSCognitoUserPool_SmsAuthenticationMessage (81.63s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration (129.93s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_ExternalId (121.34s)
--- PASS: TestAccAWSCognitoUserPool_SmsConfiguration_SnsCallerArn (109.63s)
--- PASS: TestAccAWSCognitoUserPool_SmsVerificationMessage (79.68s)
--- PASS: TestAccAWSCognitoUserPool_withTags (111.92s)
--- PASS: TestAccAWSCognitoUserPool_withAliasAttributes (79.91s)
--- PASS: TestAccAWSCognitoUserPool_withPasswordPolicy (79.13s)
--- PASS: TestAccAWSCognitoUserPool_withUsernameConfiguration (80.23s)
--- PASS: TestAccAWSCognitoUserPool_withLambdaConfig (126.40s)
--- PASS: TestAccAWSCognitoUserPool_withSchemaAttributes (84.25s)
--- PASS: TestAccAWSCognitoUserPool_withVerificationMessageTemplate (77.63s)
--- PASS: TestAccAWSCognitoUserPool_update (143.22s)

--- FAIL: TestAccAWSCognitoUserPool_withEmailConfiguration (63.24s)

TestAccAWSCognitoUserPool_withEmailConfiguration seems to have failed but i dont think its relevant the changes as it failed on:

2020/03/18 13:57:20 [ERROR] <root>: eval: *terraform.EvalApplyPost, err: Error updating Cognito User pool: InvalidParameterException: Unable to send email message, please try again
2020/03/18 13:57:20 [ERROR] <root>: eval: *terraform.EvalSequence, err: Error updating Cognito User pool: InvalidParameterException: Unable to send email message, please try again
2020/03/18 13:57:20 [DEBUG] New state was assigned lineage "b19a8bb8-2e21-41f7-1e30-be8390d53f9f"
    TestAccAWSCognitoUserPool_withEmailConfiguration: testing.go:654: Step 2 error: errors during apply:
        
        Error: Error updating Cognito User pool: InvalidParameterException: Unable to send email message, please try again
        
          on C:\Users\ilial\AppData\Local\Temp\tf-test650923783\main.tf line 2:
          (source code not available)

[ewbankkit]

Verified acceptance test:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSCognitoUserPool_recovery'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPool_recovery -timeout 120m
=== RUN   TestAccAWSCognitoUserPool_recovery
=== PAUSE TestAccAWSCognitoUserPool_recovery
=== CONT  TestAccAWSCognitoUserPool_recovery
--- PASS: TestAccAWSCognitoUserPool_recovery (61.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.273s

[michaelgmcd]

Hello, what's the status on this?

[judedaryl]

bump for status

[emulanob]

Hi, is this planned to be merged any time soon?

[seanlynch]

I've been using a build of the AWS provider with this PR merged to manage some rather complicated AWS infrastructure including multiple Cognito pools for over a month now with no problems. Can one of the maintainers please explain what still remains to be done for this to be mergeable? The lack of this feature is causing a lot of extra work for a lot of people.

[DrFaust92]

rebased and tested

[DrFaust92]

renamed recovery_mechanisms to recovery_mechanism and tested.

[jeffrystev]

Did the above issue resolved ? Do we have any new parameters in terraform in order to update the recovery of account configuration in cognito . If so kindly update the newly added parameter over here.

[cfernandez-outset]

is this merged? thank you

[seanlynch]

What's missing in order to merge this? It's costing us a lot to have to maintain our own build of the AWS provider just to get this one missing feature.

[bill-rich]

Just the one minor capitalization fix. Other than that, looks good.

[bill-rich]

LGTM

[ghost]

This has been released in version 3.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[rpstreef]

What's missing in order to merge this? It's costing us a lot to have to maintain our own build of the AWS provider just to get this one missing feature.

this is a regular issue with Terraform providers to get new features implemented in a timely manner.

Perhaps there's a good reason for it, but it might be worth reviewing why time to release is 6 months+ and sometimes even 12 months + and see if there are ways to reduce this.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!