r/aws_opsworks_custom_layer - add cloudwatch configuration + disappears test

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #2656
Closes #15010
Relates #13826

Release note for CHANGELOG:

resource_aws_opsworks_custom_layer - add cloudwatch configuration
resource_aws_opsworks_custom_layer - add plan time validation to `ebs_volume.type`

Output from acceptance testing:

$ make testacc TESTS=TestAccOpsWorksCustomLayer_ PKG=opsworks
--- PASS: TestAccOpsWorksCustomLayer_basic (112.16s)
--- PASS: TestAccOpsWorksCustomLayer_disappears (125.37s)
--- PASS: TestAccOpsWorksCustomLayer_noVPC (221.92s)
--- PASS: TestAccOpsWorksCustomLayer_cloudwatch (280.16s)
--- PASS: TestAccOpsWorksCustomLayer_tags (364.21s)

[ewbankkit]

Validated acceptance test:

$ AWS_DEFAULT_REGION=us-east-1 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSOpsworksCustomLayer_cloudwatch'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSOpsworksCustomLayer_cloudwatch -timeout 120m
=== RUN   TestAccAWSOpsworksCustomLayer_cloudwatch
=== PAUSE TestAccAWSOpsworksCustomLayer_cloudwatch
=== CONT  TestAccAWSOpsworksCustomLayer_cloudwatch
--- PASS: TestAccAWSOpsworksCustomLayer_cloudwatch (59.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.014s

[DrFaust92]

rebased:

--- PASS: TestAccAWSOpsworksCustomLayer_disappears (75.28s)
--- PASS: TestAccAWSOpsworksCustomLayer_basic (83.32s)
--- PASS: TestAccAWSOpsworksCustomLayer_noVPC (116.26s)
--- PASS: TestAccAWSOpsworksCustomLayer_cloudwatch (151.43s)
--- PASS: TestAccAWSOpsworksCustomLayer_tags (203.47s)

[ewbankkit]

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSOpsworksCustomLayer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSOpsworksCustomLayer_ -timeout 180m
=== RUN   TestAccAWSOpsworksCustomLayer_basic
=== PAUSE TestAccAWSOpsworksCustomLayer_basic
=== RUN   TestAccAWSOpsworksCustomLayer_tags
=== PAUSE TestAccAWSOpsworksCustomLayer_tags
=== RUN   TestAccAWSOpsworksCustomLayer_noVPC
=== PAUSE TestAccAWSOpsworksCustomLayer_noVPC
=== RUN   TestAccAWSOpsworksCustomLayer_cloudwatch
=== PAUSE TestAccAWSOpsworksCustomLayer_cloudwatch
=== RUN   TestAccAWSOpsworksCustomLayer_disappears
=== PAUSE TestAccAWSOpsworksCustomLayer_disappears
=== CONT  TestAccAWSOpsworksCustomLayer_basic
=== CONT  TestAccAWSOpsworksCustomLayer_cloudwatch
=== CONT  TestAccAWSOpsworksCustomLayer_noVPC
=== CONT  TestAccAWSOpsworksCustomLayer_tags
=== CONT  TestAccAWSOpsworksCustomLayer_disappears
--- PASS: TestAccAWSOpsworksCustomLayer_disappears (43.27s)
--- PASS: TestAccAWSOpsworksCustomLayer_basic (49.63s)
--- PASS: TestAccAWSOpsworksCustomLayer_noVPC (60.84s)
--- PASS: TestAccAWSOpsworksCustomLayer_cloudwatch (74.55s)
--- PASS: TestAccAWSOpsworksCustomLayer_tags (99.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	100.103s

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[DrFaust92]

rebased:

--- PASS: TestAccOpsWorksCustomLayer_basic (112.16s)
--- PASS: TestAccOpsWorksCustomLayer_disappears (125.37s)
--- PASS: TestAccOpsWorksCustomLayer_noVPC (221.92s)
--- PASS: TestAccOpsWorksCustomLayer_cloudwatch (280.16s)
--- PASS: TestAccOpsWorksCustomLayer_tags (364.21s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccOpsWorksCustomLayer_ PKG=opsworks
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opsworks/... -v -count 1 -parallel 20 -run='TestAccOpsWorksCustomLayer_'  -timeout 180m
=== RUN   TestAccOpsWorksCustomLayer_basic
=== PAUSE TestAccOpsWorksCustomLayer_basic
=== RUN   TestAccOpsWorksCustomLayer_tags
=== PAUSE TestAccOpsWorksCustomLayer_tags
=== RUN   TestAccOpsWorksCustomLayer_noVPC
=== PAUSE TestAccOpsWorksCustomLayer_noVPC
=== RUN   TestAccOpsWorksCustomLayer_cloudwatch
=== PAUSE TestAccOpsWorksCustomLayer_cloudwatch
=== RUN   TestAccOpsWorksCustomLayer_disappears
=== PAUSE TestAccOpsWorksCustomLayer_disappears
=== CONT  TestAccOpsWorksCustomLayer_basic
=== CONT  TestAccOpsWorksCustomLayer_cloudwatch
=== CONT  TestAccOpsWorksCustomLayer_noVPC
=== CONT  TestAccOpsWorksCustomLayer_disappears
=== CONT  TestAccOpsWorksCustomLayer_tags
--- PASS: TestAccOpsWorksCustomLayer_disappears (52.89s)
--- PASS: TestAccOpsWorksCustomLayer_basic (70.77s)
--- PASS: TestAccOpsWorksCustomLayer_noVPC (80.00s)
--- PASS: TestAccOpsWorksCustomLayer_cloudwatch (108.23s)
--- PASS: TestAccOpsWorksCustomLayer_tags (116.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opsworks	122.059s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.