add data ec2 transit gateway vpc attatchments #12409

Maarc-D · 2020-03-16T14:23:58Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Add new data source  aws_ec2_transit_gateway_vpc_attachments

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

… list of all vpnc attachments matching criterias and not only one

…pointed by 'go fmt'

…of append

ewbankkit · 2020-03-17T12:20:31Z

@Maarc-D Thanks for tackling this.
It may be simpler for this data source to simply return a set of matching resource IDs and then use the aws_ec2_transit_gateway_vpc_attachment with count and index to get information about each attachment.
This is similar to the pattern used with other data sources such as aws_ebs_snapshotd_id / aws_ebs_snapshot.

Maarc-D · 2020-03-19T10:32:43Z

@Maarc-D Thanks for tackling this.
It may be simpler for this data source to simply return a set of matching resource IDs and then use the aws_ec2_transit_gateway_vpc_attachment with count and index to get information about each attachment.
This is similar to the pattern used with other data sources such as aws_ebs_snapshotd_id / aws_ebs_snapshot.

Hello,
yes why not, I don't really know the best way to do so to fit provider requirement. My need is on other fields that ID that why I try tu put an array off attachment

I don't really know the better way and where are the guidelines about this :/
Regards Marc.

…ation syntaxe

…d to erb

…sed var

…o fit existing and just return list of ids

Maarc-D · 2020-04-07T13:17:51Z

Hello,
according to comment of @ewbankkit I change to return list of ids
Regards Marc.

…tion to match changed impementation

Acceptance test output: % make testacc TESTS=TestAccEC2VPCPeeringConnection_basic PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2VPCPeeringConnection_basic' -timeout 180m === RUN TestAccEC2VPCPeeringConnection_basic === PAUSE TestAccEC2VPCPeeringConnection_basic === CONT TestAccEC2VPCPeeringConnection_basic --- PASS: TestAccEC2VPCPeeringConnection_basic (33.35s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 37.632s

Acceptance test output: % make testacc TESTS=TestAccEC2VPCPeeringConnection_ PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run='TestAccEC2VPCPeeringConnection_' -timeout 180m === RUN TestAccEC2VPCPeeringConnection_basic === PAUSE TestAccEC2VPCPeeringConnection_basic === RUN TestAccEC2VPCPeeringConnection_disappears === PAUSE TestAccEC2VPCPeeringConnection_disappears === RUN TestAccEC2VPCPeeringConnection_tags === PAUSE TestAccEC2VPCPeeringConnection_tags === RUN TestAccEC2VPCPeeringConnection_options === PAUSE TestAccEC2VPCPeeringConnection_options === RUN TestAccEC2VPCPeeringConnection_failedState === PAUSE TestAccEC2VPCPeeringConnection_failedState === RUN TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === PAUSE TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === RUN TestAccEC2VPCPeeringConnection_region === PAUSE TestAccEC2VPCPeeringConnection_region === RUN TestAccEC2VPCPeeringConnection_accept === PAUSE TestAccEC2VPCPeeringConnection_accept === RUN TestAccEC2VPCPeeringConnection_optionsNoAutoAccept === PAUSE TestAccEC2VPCPeeringConnection_optionsNoAutoAccept === CONT TestAccEC2VPCPeeringConnection_basic === CONT TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === CONT TestAccEC2VPCPeeringConnection_options --- PASS: TestAccEC2VPCPeeringConnection_peerRegionAutoAccept (16.50s) === CONT TestAccEC2VPCPeeringConnection_failedState --- PASS: TestAccEC2VPCPeeringConnection_failedState (16.42s) === CONT TestAccEC2VPCPeeringConnection_tags --- PASS: TestAccEC2VPCPeeringConnection_basic (34.74s) === CONT TestAccEC2VPCPeeringConnection_optionsNoAutoAccept --- PASS: TestAccEC2VPCPeeringConnection_optionsNoAutoAccept (28.04s) === CONT TestAccEC2VPCPeeringConnection_region --- PASS: TestAccEC2VPCPeeringConnection_options (68.20s) === CONT TestAccEC2VPCPeeringConnection_disappears --- PASS: TestAccEC2VPCPeeringConnection_disappears (28.36s) === CONT TestAccEC2VPCPeeringConnection_accept --- PASS: TestAccEC2VPCPeeringConnection_region (34.07s) --- PASS: TestAccEC2VPCPeeringConnection_tags (77.26s) --- PASS: TestAccEC2VPCPeeringConnection_accept (74.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 178.607s

r/aws_vpc_peering_connection_options: Tidy up. Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnection_\|TestAccEC2VPCPeeringConnectionOptions_\|TestAccEC2VPCPeeringConnectionAccepter_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VPCPeeringConnection_\|TestAccEC2VPCPeeringConnectionOptions_\|TestAccEC2VPCPeeringConnectionAccepter_ -timeout 180m === RUN TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount === RUN TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount === RUN TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount === RUN TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount === RUN TestAccEC2VPCPeeringConnectionOptions_basic === PAUSE TestAccEC2VPCPeeringConnectionOptions_basic === RUN TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount === PAUSE TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount === RUN TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === PAUSE TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === RUN TestAccEC2VPCPeeringConnection_basic === PAUSE TestAccEC2VPCPeeringConnection_basic === RUN TestAccEC2VPCPeeringConnection_disappears === PAUSE TestAccEC2VPCPeeringConnection_disappears === RUN TestAccEC2VPCPeeringConnection_tags === PAUSE TestAccEC2VPCPeeringConnection_tags === RUN TestAccEC2VPCPeeringConnection_options === PAUSE TestAccEC2VPCPeeringConnection_options === RUN TestAccEC2VPCPeeringConnection_failedState === PAUSE TestAccEC2VPCPeeringConnection_failedState === RUN TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === PAUSE TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === RUN TestAccEC2VPCPeeringConnection_region === PAUSE TestAccEC2VPCPeeringConnection_region === RUN TestAccEC2VPCPeeringConnection_accept === PAUSE TestAccEC2VPCPeeringConnection_accept === RUN TestAccEC2VPCPeeringConnection_optionsNoAutoAccept === PAUSE TestAccEC2VPCPeeringConnection_optionsNoAutoAccept === CONT TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount === CONT TestAccEC2VPCPeeringConnection_disappears === CONT TestAccEC2VPCPeeringConnectionOptions_basic --- PASS: TestAccEC2VPCPeeringConnection_disappears (30.57s) === CONT TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount acctest.go:599: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account. --- SKIP: TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount (0.05s) === CONT TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount acctest.go:599: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account. --- SKIP: TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount (0.05s) === CONT TestAccEC2VPCPeeringConnection_basic --- PASS: TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount (35.20s) === CONT TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount acctest.go:599: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account. --- SKIP: TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount (0.05s) === CONT TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount --- PASS: TestAccEC2VPCPeeringConnection_basic (33.82s) === CONT TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount --- PASS: TestAccEC2VPCPeeringConnectionOptions_basic (73.77s) === CONT TestAccEC2VPCPeeringConnection_options --- PASS: TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount (41.45s) === CONT TestAccEC2VPCPeeringConnection_peerRegionAutoAccept --- PASS: TestAccEC2VPCPeeringConnection_peerRegionAutoAccept (14.34s) === CONT TestAccEC2VPCPeeringConnection_failedState --- PASS: TestAccEC2VPCPeeringConnection_failedState (16.04s) === CONT TestAccEC2VPCPeeringConnection_optionsNoAutoAccept --- PASS: TestAccEC2VPCPeeringConnection_optionsNoAutoAccept (29.37s) === CONT TestAccEC2VPCPeeringConnection_region --- PASS: TestAccEC2VPCPeeringConnection_options (68.49s) === CONT TestAccEC2VPCPeeringConnection_tags --- PASS: TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount (80.40s) === CONT TestAccEC2VPCPeeringConnection_accept --- PASS: TestAccEC2VPCPeeringConnection_region (37.49s) === CONT TestAccEC2VPCPeeringConnection_accept vpc_peering_connection_test.go:341: Step 2/4 error: Check failed: Check 2/2 error: aws_vpc_peering_connection.test: Attribute 'accept_status' expected "active", got "pending-acceptance" --- FAIL: TestAccEC2VPCPeeringConnection_accept (42.74s) --- PASS: TestAccEC2VPCPeeringConnection_tags (77.39s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 223.670s FAIL make: *** [testacc] Error 1

…t.DeepEqual'. Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnectionOptions_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VPCPeeringConnectionOptions_ -timeout 180m === RUN TestAccEC2VPCPeeringConnectionOptions_basic === PAUSE TestAccEC2VPCPeeringConnectionOptions_basic === RUN TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount === PAUSE TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount === RUN TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === PAUSE TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === CONT TestAccEC2VPCPeeringConnectionOptions_basic === CONT TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === CONT TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount === CONT TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount acctest.go:599: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account. --- SKIP: TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount (1.47s) --- PASS: TestAccEC2VPCPeeringConnectionOptions_basic (69.69s) --- PASS: TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount (113.94s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 117.605s

% make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnection_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VPCPeeringConnection_ -timeout 180m === RUN TestAccEC2VPCPeeringConnection_basic === PAUSE TestAccEC2VPCPeeringConnection_basic === RUN TestAccEC2VPCPeeringConnection_disappears === PAUSE TestAccEC2VPCPeeringConnection_disappears === RUN TestAccEC2VPCPeeringConnection_tags === PAUSE TestAccEC2VPCPeeringConnection_tags === RUN TestAccEC2VPCPeeringConnection_options === PAUSE TestAccEC2VPCPeeringConnection_options === RUN TestAccEC2VPCPeeringConnection_failedState === PAUSE TestAccEC2VPCPeeringConnection_failedState === RUN TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === PAUSE TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === RUN TestAccEC2VPCPeeringConnection_region === PAUSE TestAccEC2VPCPeeringConnection_region === RUN TestAccEC2VPCPeeringConnection_accept === PAUSE TestAccEC2VPCPeeringConnection_accept === RUN TestAccEC2VPCPeeringConnection_optionsNoAutoAccept === PAUSE TestAccEC2VPCPeeringConnection_optionsNoAutoAccept === CONT TestAccEC2VPCPeeringConnection_basic === CONT TestAccEC2VPCPeeringConnection_peerRegionAutoAccept === CONT TestAccEC2VPCPeeringConnection_options --- PASS: TestAccEC2VPCPeeringConnection_peerRegionAutoAccept (16.27s) === CONT TestAccEC2VPCPeeringConnection_failedState --- PASS: TestAccEC2VPCPeeringConnection_failedState (16.74s) === CONT TestAccEC2VPCPeeringConnection_accept --- PASS: TestAccEC2VPCPeeringConnection_basic (35.12s) === CONT TestAccEC2VPCPeeringConnection_optionsNoAutoAccept --- PASS: TestAccEC2VPCPeeringConnection_optionsNoAutoAccept (26.46s) === CONT TestAccEC2VPCPeeringConnection_tags --- PASS: TestAccEC2VPCPeeringConnection_options (68.15s) === CONT TestAccEC2VPCPeeringConnection_region --- PASS: TestAccEC2VPCPeeringConnection_region (32.27s) === CONT TestAccEC2VPCPeeringConnection_disappears --- PASS: TestAccEC2VPCPeeringConnection_accept (74.73s) --- PASS: TestAccEC2VPCPeeringConnection_disappears (27.15s) --- PASS: TestAccEC2VPCPeeringConnection_tags (75.10s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 140.355s % make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnectionAccepter_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VPCPeeringConnectionAccepter_ -timeout 180m === RUN TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount === RUN TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount === RUN TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount === RUN TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount === PAUSE TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount === CONT TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount === CONT TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount === CONT TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount --- PASS: TestAccEC2VPCPeeringConnectionAccepter_sameRegionSameAccount (34.16s) === CONT TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount --- PASS: TestAccEC2VPCPeeringConnectionAccepter_sameRegionDifferentAccount (34.27s) --- PASS: TestAccEC2VPCPeeringConnectionAccepter_differentRegionSameAccount (44.26s) --- PASS: TestAccEC2VPCPeeringConnectionAccepter_differentRegionDifferentAccount (40.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 78.772s % make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnectionOptions_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VPCPeeringConnectionOptions_ -timeout 180m === RUN TestAccEC2VPCPeeringConnectionOptions_basic === PAUSE TestAccEC2VPCPeeringConnectionOptions_basic === RUN TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount === PAUSE TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount === RUN TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === PAUSE TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === CONT TestAccEC2VPCPeeringConnectionOptions_basic === CONT TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount === CONT TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount --- PASS: TestAccEC2VPCPeeringConnectionOptions_sameRegionDifferentAccount (56.44s) --- PASS: TestAccEC2VPCPeeringConnectionOptions_basic (69.69s) --- PASS: TestAccEC2VPCPeeringConnectionOptions_differentRegionSameAccount (85.41s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 89.065s

Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnectionDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VPCPeeringConnectionDataSource_ -timeout 180m === RUN TestAccEC2VPCPeeringConnectionDataSource_cidrBlock === PAUSE TestAccEC2VPCPeeringConnectionDataSource_cidrBlock === RUN TestAccEC2VPCPeeringConnectionDataSource_id === PAUSE TestAccEC2VPCPeeringConnectionDataSource_id === RUN TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock === PAUSE TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock === RUN TestAccEC2VPCPeeringConnectionDataSource_peerVPCID === PAUSE TestAccEC2VPCPeeringConnectionDataSource_peerVPCID === RUN TestAccEC2VPCPeeringConnectionDataSource_vpcID === PAUSE TestAccEC2VPCPeeringConnectionDataSource_vpcID === CONT TestAccEC2VPCPeeringConnectionDataSource_cidrBlock === CONT TestAccEC2VPCPeeringConnectionDataSource_peerVPCID === CONT TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock --- PASS: TestAccEC2VPCPeeringConnectionDataSource_peerVPCID (31.16s) === CONT TestAccEC2VPCPeeringConnectionDataSource_id --- PASS: TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock (38.86s) === CONT TestAccEC2VPCPeeringConnectionDataSource_vpcID --- PASS: TestAccEC2VPCPeeringConnectionDataSource_cidrBlock (38.91s) --- PASS: TestAccEC2VPCPeeringConnectionDataSource_id (30.19s) --- PASS: TestAccEC2VPCPeeringConnectionDataSource_vpcID (29.77s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 72.197s

Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnectionsDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccEC2VPCPeeringConnectionsDataSource_ -timeout 180m === RUN TestAccEC2VPCPeeringConnectionsDataSource_basic === PAUSE TestAccEC2VPCPeeringConnectionsDataSource_basic === RUN TestAccEC2VPCPeeringConnectionsDataSource_NoMatches === PAUSE TestAccEC2VPCPeeringConnectionsDataSource_NoMatches === CONT TestAccEC2VPCPeeringConnectionsDataSource_basic === CONT TestAccEC2VPCPeeringConnectionsDataSource_NoMatches --- PASS: TestAccEC2VPCPeeringConnectionsDataSource_NoMatches (14.59s) --- PASS: TestAccEC2VPCPeeringConnectionsDataSource_basic (30.41s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 34.278s

n3mawashi · 2022-02-22T01:53:39Z

@Maarc-D, I'm really keen on this for selfish purposes. Do you need a hand resolving the conflict it can be reviewed and merged?

…ges world. Acceptance test output: % make testacc TESTS=TestAccEC2TransitGatewayDataSource_serial/VpcAttachments PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGatewayDataSource_serial/VpcAttachments' -timeout 180m === RUN TestAccEC2TransitGatewayDataSource_serial === RUN TestAccEC2TransitGatewayDataSource_serial/VpcAttachments === RUN TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter === PAUSE TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter === CONT TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter --- PASS: TestAccEC2TransitGatewayDataSource_serial (429.60s) --- PASS: TestAccEC2TransitGatewayDataSource_serial/VpcAttachments (0.00s) --- PASS: TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter (429.60s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 434.980s

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTS=TestAccEC2TransitGatewayDataSource_serial/VpcAttachments PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGatewayDataSource_serial/VpcAttachments'  -timeout 180m
=== RUN   TestAccEC2TransitGatewayDataSource_serial
=== RUN   TestAccEC2TransitGatewayDataSource_serial/VpcAttachments
=== RUN   TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter
=== PAUSE TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter
=== CONT  TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter
--- PASS: TestAccEC2TransitGatewayDataSource_serial (429.60s)
    --- PASS: TestAccEC2TransitGatewayDataSource_serial/VpcAttachments (0.00s)
        --- PASS: TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter (429.60s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	434.980s

GovCloud

% make testacc TESTS=TestAccEC2TransitGatewayDataSource_serial/VpcAttachments PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2TransitGatewayDataSource_serial/VpcAttachments'  -timeout 180m
=== RUN   TestAccEC2TransitGatewayDataSource_serial
=== RUN   TestAccEC2TransitGatewayDataSource_serial/VpcAttachments
=== RUN   TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter
=== PAUSE TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter
=== CONT  TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter
--- PASS: TestAccEC2TransitGatewayDataSource_serial (371.43s)
    --- PASS: TestAccEC2TransitGatewayDataSource_serial/VpcAttachments (0.00s)
        --- PASS: TestAccEC2TransitGatewayDataSource_serial/VpcAttachments/Filter (371.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	376.277s

…to VPC Peering eventual consistency check.

ewbankkit · 2022-02-24T14:21:47Z

For the VPC Peering changes:

% make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnectionsDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2VPCPeeringConnectionsDataSource_ -timeout 180m
=== RUN   TestAccEC2VPCPeeringConnectionsDataSource_basic
=== PAUSE TestAccEC2VPCPeeringConnectionsDataSource_basic
=== RUN   TestAccEC2VPCPeeringConnectionsDataSource_NoMatches
=== PAUSE TestAccEC2VPCPeeringConnectionsDataSource_NoMatches
=== CONT  TestAccEC2VPCPeeringConnectionsDataSource_basic
=== CONT  TestAccEC2VPCPeeringConnectionsDataSource_NoMatches
--- PASS: TestAccEC2VPCPeeringConnectionsDataSource_NoMatches (12.16s)
--- PASS: TestAccEC2VPCPeeringConnectionsDataSource_basic (20.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	24.007s
% make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnectionDataSource_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2VPCPeeringConnectionDataSource_ -timeout 180m
=== RUN   TestAccEC2VPCPeeringConnectionDataSource_cidrBlock
=== PAUSE TestAccEC2VPCPeeringConnectionDataSource_cidrBlock
=== RUN   TestAccEC2VPCPeeringConnectionDataSource_id
=== PAUSE TestAccEC2VPCPeeringConnectionDataSource_id
=== RUN   TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock
=== PAUSE TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock
=== RUN   TestAccEC2VPCPeeringConnectionDataSource_peerVPCID
=== PAUSE TestAccEC2VPCPeeringConnectionDataSource_peerVPCID
=== RUN   TestAccEC2VPCPeeringConnectionDataSource_vpcID
=== PAUSE TestAccEC2VPCPeeringConnectionDataSource_vpcID
=== CONT  TestAccEC2VPCPeeringConnectionDataSource_cidrBlock
=== CONT  TestAccEC2VPCPeeringConnectionDataSource_vpcID
=== CONT  TestAccEC2VPCPeeringConnectionDataSource_peerVPCID
--- PASS: TestAccEC2VPCPeeringConnectionDataSource_vpcID (19.36s)
=== CONT  TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock
--- PASS: TestAccEC2VPCPeeringConnectionDataSource_peerVPCID (19.44s)
=== CONT  TestAccEC2VPCPeeringConnectionDataSource_id
--- PASS: TestAccEC2VPCPeeringConnectionDataSource_cidrBlock (22.03s)
--- PASS: TestAccEC2VPCPeeringConnectionDataSource_id (18.89s)
--- PASS: TestAccEC2VPCPeeringConnectionDataSource_peerCIDRBlock (76.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	99.028s
% make testacc TESTARGS='-run=TestAccEC2VPCPeeringConnection_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2VPCPeeringConnection_ -timeout 180m
=== RUN   TestAccEC2VPCPeeringConnection_basic
=== PAUSE TestAccEC2VPCPeeringConnection_basic
=== RUN   TestAccEC2VPCPeeringConnection_disappears
=== PAUSE TestAccEC2VPCPeeringConnection_disappears
=== RUN   TestAccEC2VPCPeeringConnection_tags
=== PAUSE TestAccEC2VPCPeeringConnection_tags
=== RUN   TestAccEC2VPCPeeringConnection_options
=== PAUSE TestAccEC2VPCPeeringConnection_options
=== RUN   TestAccEC2VPCPeeringConnection_failedState
=== PAUSE TestAccEC2VPCPeeringConnection_failedState
=== RUN   TestAccEC2VPCPeeringConnection_peerRegionAutoAccept
=== PAUSE TestAccEC2VPCPeeringConnection_peerRegionAutoAccept
=== RUN   TestAccEC2VPCPeeringConnection_region
=== PAUSE TestAccEC2VPCPeeringConnection_region
=== RUN   TestAccEC2VPCPeeringConnection_accept
=== PAUSE TestAccEC2VPCPeeringConnection_accept
=== RUN   TestAccEC2VPCPeeringConnection_optionsNoAutoAccept
=== PAUSE TestAccEC2VPCPeeringConnection_optionsNoAutoAccept
=== CONT  TestAccEC2VPCPeeringConnection_basic
=== CONT  TestAccEC2VPCPeeringConnection_peerRegionAutoAccept
--- PASS: TestAccEC2VPCPeeringConnection_peerRegionAutoAccept (11.42s)
=== CONT  TestAccEC2VPCPeeringConnection_options
--- PASS: TestAccEC2VPCPeeringConnection_basic (21.40s)
=== CONT  TestAccEC2VPCPeeringConnection_failedState
--- PASS: TestAccEC2VPCPeeringConnection_failedState (11.63s)
=== CONT  TestAccEC2VPCPeeringConnection_tags
--- PASS: TestAccEC2VPCPeeringConnection_options (44.03s)
=== CONT  TestAccEC2VPCPeeringConnection_disappears
--- PASS: TestAccEC2VPCPeeringConnection_disappears (17.07s)
=== CONT  TestAccEC2VPCPeeringConnection_accept
--- PASS: TestAccEC2VPCPeeringConnection_tags (46.71s)
=== CONT  TestAccEC2VPCPeeringConnection_optionsNoAutoAccept
--- PASS: TestAccEC2VPCPeeringConnection_optionsNoAutoAccept (21.86s)
=== CONT  TestAccEC2VPCPeeringConnection_region
--- PASS: TestAccEC2VPCPeeringConnection_accept (46.32s)
--- PASS: TestAccEC2VPCPeeringConnection_region (21.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	127.073s

ewbankkit · 2022-02-24T14:22:05Z

@Maarc-D Thanks for the contribution 🎉 👏.

github-actions · 2022-03-01T22:09:18Z

This functionality has been released in v4.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-13T02:39:38Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Maarc-D added 3 commits March 12, 2020 09:54

feat(add-data-ec2-transit-gateway-vpc-attatchments): be able to get a…

231fa03

… list of all vpnc attachments matching criterias and not only one

feat(add-data-ec2-transit-gateway-vpc-attatchments): adaptation

a9259a2

feat(add-data-ec2-transit-gateway-vpc-attatchments): correct syntaxe …

afb8063

…pointed by 'go fmt'

Maarc-D requested a review from a team March 16, 2020 14:23

ghost added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 16, 2020

Maarc-D force-pushed the feat/add-data-ec2-transit-gateway-vpc-attatchments branch from 2f9ae0e to c2a13b0 Compare March 17, 2020 07:23

feat(add-data-ec2-transit-gateway-vpc-attatchments): correct syntaxe …

6785560

…of append

Maarc-D force-pushed the feat/add-data-ec2-transit-gateway-vpc-attatchments branch from c2a13b0 to 6785560 Compare March 17, 2020 07:34

David Quagebeur and others added 2 commits March 24, 2020 14:13

fix: syntax errors

bbbcef0

feat(add-data-ec2-transit-gateway-vpc-attatchments): add documentation

f780c55

ghost added documentation Introduces or discusses updates to documentation. size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 26, 2020

feat(add-data-ec2-transit-gateway-vpc-attatchments): add test

2ad1f0e

ghost added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Mar 26, 2020

Maarc-D and others added 5 commits March 26, 2020 09:14

feat(add-data-ec2-transit-gateway-vpc-attatchments): correct document…

4251963

…ation syntaxe

feat(add-data-ec2-transit-gateway-vpc-attatchments): documentation ad…

2ec9856

…d to erb

feat(add-data-ec2-transit-gateway-vpc-attatchments): correct test unu…

a368fd1

…sed var

fix tests

10fa116

reference aws_ec2_transit_gateway_vpc_attachments in providers

3e61e55

ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Apr 7, 2020

feat(add-data-ec2-transit-gateway-vpc-attatchments): change mindset t…

b84cd44

…o fit existing and just return list of ids

Maarc-D and others added 2 commits April 7, 2020 09:31

feat(add-data-ec2-transit-gateway-vpc-attatchments): change documenta…

5dc4480

…tion to match changed impementation

refactor

bd3bb89

ghost added the service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. label Apr 7, 2020

ewbankkit added 9 commits February 10, 2022 09:59

d/aws_vpc_peering_connection: Alphabetize attributes.

63fc8d7

r/aws_vpc_peering_connection: Tidy up sweeper.

6f858f3

ewbankkit added 5 commits February 23, 2022 18:26

Merge branch 'main' into td-tidy-up-vpc-peering-connection

051644f

Merge branch 'td-tidy-up-vpc-peering-connection' into HEAD

04c7984

Move new source files to correct service package.

cdd7321

Add CHANGELOG entry.

f20cfe7

github-actions bot added sweeper Pertains to changes to or issues with the sweeper. size/XL Managed by automation to categorize the size of a PR. and removed service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. labels Feb 24, 2022

Remove trailing space from documentation.

9a53e29

ewbankkit approved these changes Feb 24, 2022

View reviewed changes

Add 'nosem: helper-schema-resource-Retry-without-TimeoutError-check' …

75a18ca

…to VPC Peering eventual consistency check.

ewbankkit removed the size/XXL Managed by automation to categorize the size of a PR. label Feb 24, 2022

ewbankkit merged commit 3839bc6 into hashicorp:main Feb 24, 2022

github-actions bot added this to the v4.3.0 milestone Feb 24, 2022

ewbankkit mentioned this pull request Feb 24, 2022

Fix go.mod #23361

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add data ec2 transit gateway vpc attatchments #12409

add data ec2 transit gateway vpc attatchments #12409

Maarc-D commented Mar 16, 2020 •

edited by ewbankkit

Loading

ewbankkit commented Mar 17, 2020

Maarc-D commented Mar 19, 2020

Maarc-D commented Apr 7, 2020

n3mawashi commented Feb 22, 2022

ewbankkit left a comment

ewbankkit commented Feb 24, 2022

ewbankkit commented Feb 24, 2022

github-actions bot commented Mar 1, 2022

github-actions bot commented May 13, 2022

add data ec2 transit gateway vpc attatchments #12409

add data ec2 transit gateway vpc attatchments #12409

Conversation

Maarc-D commented Mar 16, 2020 • edited by ewbankkit Loading

Community Note

ewbankkit commented Mar 17, 2020

Maarc-D commented Mar 19, 2020

Maarc-D commented Apr 7, 2020

n3mawashi commented Feb 22, 2022

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Feb 24, 2022

ewbankkit commented Feb 24, 2022

github-actions bot commented Mar 1, 2022

github-actions bot commented May 13, 2022

Maarc-D commented Mar 16, 2020 •

edited by ewbankkit

Loading