Enhancement: Step Functions for Express Workflows #12249

grahamjenson · 2020-03-04T15:06:30Z

Improved from #11570

This adds support for AWS Step Functions for Express Workflows, that are ideal for high-volume, event-processing workloads such as IoT data ingestion, streaming data processing and transformation, and mobile application backends. They can run for up to five minutes. Execution history is optionally available in Amazon CloudWatch Logs. Express Workflows employ an at-least-once model, where there is a possibility that an execution might be run more than once. This makes them ideal for orchestrating idempotent actions such as transforming input data and storing via PUT in Amazon DynamoDB. Express Workflow executions are billed by the number of executions, the duration of execution, and the memory consumed.

Changes proposed in this pull request:
resource_aws_sfn_state_machine.go: Add type and logging_configuration arguments
resource_aws_sfn_state_machine_test.go: Extend acceptance tests
sfn_state_machine.html.markdown: Extend documentation

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #11348 #11374 #12192 #11570

Release note for CHANGELOG:

IMPROVEMENTS:
Add `type` and `logging_configuration` arguments: aws_sfn_state_machine

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSfnStateMachine'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSfnStateMachine -timeout 120m
=== RUN   TestAccAWSSfnStateMachine_createUpdate
=== PAUSE TestAccAWSSfnStateMachine_createUpdate
=== RUN   TestAccAWSSfnStateMachine_express_createUpdate
=== PAUSE TestAccAWSSfnStateMachine_express_createUpdate
=== RUN   TestAccAWSSfnStateMachine_standard_createUpdate
=== PAUSE TestAccAWSSfnStateMachine_standard_createUpdate
=== RUN   TestAccAWSSfnStateMachine_Tags
=== PAUSE TestAccAWSSfnStateMachine_Tags
=== RUN   TestAccAWSSfnStateMachine_express_LoggingConfiguration
=== PAUSE TestAccAWSSfnStateMachine_express_LoggingConfiguration
=== CONT  TestAccAWSSfnStateMachine_createUpdate
=== CONT  TestAccAWSSfnStateMachine_Tags
=== CONT  TestAccAWSSfnStateMachine_standard_createUpdate
=== CONT  TestAccAWSSfnStateMachine_express_createUpdate
=== CONT  TestAccAWSSfnStateMachine_express_LoggingConfiguration
--- PASS: TestAccAWSSfnStateMachine_standard_createUpdate (91.72s)
--- PASS: TestAccAWSSfnStateMachine_express_createUpdate (103.14s)
--- PASS: TestAccAWSSfnStateMachine_createUpdate (110.65s)
--- PASS: TestAccAWSSfnStateMachine_Tags (117.36s)
--- PASS: TestAccAWSSfnStateMachine_express_LoggingConfiguration (120.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	122.905s
...

grahamjenson · 2020-05-01T06:06:58Z

Updated by resolving conflict.
When can we expect this to be merged?

grahamjenson · 2020-05-14T16:45:22Z

@VVolotivskyi Bump. When is it possible to get this merged and out?

aws/resource_aws_sfn_state_machine.go

website/docs/r/sfn_state_machine.html.markdown

a087674 · 2020-06-24T17:15:49Z

@bflad - Is there any chance this can be reviewed within the next week or two?

divmgl

Approved with some minuscule polish suggestions to get the ball rolling @grahamjenson @bflad

aws/resource_aws_sfn_state_machine_test.go

website/docs/r/sfn_state_machine.html.markdown

benmcmeen

Any chance that this can be merged?

grahamjenson · 2020-07-02T00:31:13Z

@benmcmeen I hope we can get this merged. most of my time is spent just fixing conflicts.

Co-authored-by: Dexter Miguel <[email protected]>

emilioinfinity

It would be great if this could get merged.

kuhnboy · 2020-07-31T00:53:29Z

It would be great if this could get merged.

benmcmeen · 2020-09-09T13:31:43Z

So - do any of the maintainers ever review PRs on this project? This has been out there forever and contains useful features. It's radio silent on this feature and doesn't exactly inspire confidence about future enhancements or break/fix.

kuhnboy · 2020-09-09T14:18:29Z

633 open pull requests show why we shouldn’t put our faith in terraform over cdk. This will never be merged.

k1rd3rf · 2020-09-09T17:45:02Z

Community Note
Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request

Get more people to vote :)

benmcmeen · 2020-09-09T17:50:47Z

Plenty of people have voted BOTH times this PR has been submitted. It's not a community participation issue. It's a maintenance shortcoming.

andrewp-sf · 2020-09-15T07:36:14Z

@bflad When can we expect this? Because type can't be changed once state is created, I consider this to be critical. I don't see any workarounds except for this PR right now.

a087674 · 2020-09-21T21:49:01Z

@breathingdust @anGie44 Can you help in merging this PR?

breathingdust · 2020-09-30T18:27:17Z

Hi all! 👋

Just a quick update to say we are tracking this for attention in the near future, but at this time we can't give you an ETA. We appreciate your patience and hope to get back to you with an update soon.

bvicinus · 2020-12-08T17:07:06Z

Bump, any chance we can get some movement on this? No activity in over 2 months...

benmcmeen · 2020-12-08T20:24:28Z

Bump, any chance we can get some movement on this? No activity in over 2 months...

I gave up on this one a loooooong time ago. The SFN module in TF doesn't support XRay tracing, logging config, and all kinds of other things I also couldn't wait for. I ended up just managing this with a script and direct CLI call.

SebRamsland · 2021-02-02T09:07:12Z

This feature was included in the previous roadmap (November 2020 - January 2021), but apparently didn't make it. Now the issue is not mentioned in the current Roadmap nor the upcoming release (3.27.0).

What's happening?

bvicinus · 2021-02-02T14:37:17Z

Agreed w/ @SebRamsland
I was planning on this feature being available early 2021. Now it is off the roadmap?? Can we please get an update?!?

bill-rich · 2021-02-04T18:37:28Z

Sorry for the confusion on the roadmap everyone. This is being merged and will be released in v3.27.0.

ghost · 2021-02-05T00:41:32Z

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-03-07T17:11:10Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

grahamjenson requested a review from a team March 4, 2020 15:06

grahamjenson mentioned this pull request Mar 4, 2020

Enabling Step Function Logging To CloudWatch #12192

Closed

VVolotivskyi approved these changes Apr 21, 2020

View reviewed changes

dkujawski reviewed Jun 4, 2020

View reviewed changes

aws/resource_aws_sfn_state_machine.go Show resolved Hide resolved

grahamjenson force-pushed the enhancement/sfn-express-state-machine branch from 0ca9b6f to 19c70b0 Compare June 11, 2020 16:41

grahamjenson mentioned this pull request Jun 11, 2020

Enhancement: Step Functions for Express Workflows #11570

Closed

a087674 reviewed Jun 22, 2020

View reviewed changes

website/docs/r/sfn_state_machine.html.markdown Outdated Show resolved Hide resolved

divmgl approved these changes Jun 29, 2020

View reviewed changes

aws/resource_aws_sfn_state_machine_test.go Outdated Show resolved Hide resolved

aws/resource_aws_sfn_state_machine_test.go Outdated Show resolved Hide resolved

website/docs/r/sfn_state_machine.html.markdown Outdated Show resolved Hide resolved

benmcmeen approved these changes Jul 1, 2020

View reviewed changes

rockycore and others added 10 commits July 1, 2020 17:34

Enhancement: Step Functions for Express Workflows

ff67906

removed express logging restrictions

43d02c2

fenced lines fix

9ac9e57

fixing hcl styling

863f407

fix styling

c0f10b2

force new

7bcc4d0

align docs

c40cff7

Update aws/resource_aws_sfn_state_machine_test.go

4db1466

Co-authored-by: Dexter Miguel <[email protected]>

Update aws/resource_aws_sfn_state_machine_test.go

13df679

Co-authored-by: Dexter Miguel <[email protected]>

Update website/docs/r/sfn_state_machine.html.markdown

5f3f198

Co-authored-by: Dexter Miguel <[email protected]>

grahamjenson force-pushed the enhancement/sfn-express-state-machine branch from 59913fe to 5f3f198 Compare July 2, 2020 00:35

new test format

817a992

fixing linter

b99c8a8

anGie44 force-pushed the master branch from 54db70d to 48ba2f7 Compare July 21, 2020 18:27

emilioinfinity approved these changes Jul 29, 2020

View reviewed changes

Base automatically changed from master to main January 23, 2021 00:57

breathingdust requested a review from a team as a code owner January 23, 2021 00:57

Remove redundant code and modify test

e6e1404

bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Feb 3, 2021

Fix formatting

012aa79

bill-rich added this to the v3.27.0 milestone Feb 4, 2021

bill-rich merged commit 746f48f into hashicorp:main Feb 4, 2021

jaxxstorm mentioned this pull request Feb 4, 2021

Step Functions - "Express" type pulumi/pulumi-aws#982

Closed

ghost locked as resolved and limited conversation to collaborators Mar 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement: Step Functions for Express Workflows #12249

Enhancement: Step Functions for Express Workflows #12249

grahamjenson commented Mar 4, 2020 •

edited

Loading

grahamjenson commented May 1, 2020

grahamjenson commented May 14, 2020

a087674 commented Jun 24, 2020

divmgl left a comment •

edited

Loading

benmcmeen left a comment

grahamjenson commented Jul 2, 2020

emilioinfinity left a comment

kuhnboy commented Jul 31, 2020

benmcmeen commented Sep 9, 2020

kuhnboy commented Sep 9, 2020

k1rd3rf commented Sep 9, 2020

benmcmeen commented Sep 9, 2020

andrewp-sf commented Sep 15, 2020

a087674 commented Sep 21, 2020

breathingdust commented Sep 30, 2020

bvicinus commented Dec 8, 2020

benmcmeen commented Dec 8, 2020

SebRamsland commented Feb 2, 2021

bvicinus commented Feb 2, 2021

bill-rich commented Feb 4, 2021

ghost commented Feb 5, 2021

ghost commented Mar 7, 2021

Enhancement: Step Functions for Express Workflows #12249

Enhancement: Step Functions for Express Workflows #12249

Conversation

grahamjenson commented Mar 4, 2020 • edited Loading

Community Note

grahamjenson commented May 1, 2020

grahamjenson commented May 14, 2020

a087674 commented Jun 24, 2020

divmgl left a comment • edited Loading

Choose a reason for hiding this comment

benmcmeen left a comment

Choose a reason for hiding this comment

grahamjenson commented Jul 2, 2020

emilioinfinity left a comment

Choose a reason for hiding this comment

kuhnboy commented Jul 31, 2020

benmcmeen commented Sep 9, 2020

kuhnboy commented Sep 9, 2020

k1rd3rf commented Sep 9, 2020

benmcmeen commented Sep 9, 2020

andrewp-sf commented Sep 15, 2020

a087674 commented Sep 21, 2020

breathingdust commented Sep 30, 2020

bvicinus commented Dec 8, 2020

benmcmeen commented Dec 8, 2020

SebRamsland commented Feb 2, 2021

bvicinus commented Feb 2, 2021

bill-rich commented Feb 4, 2021

ghost commented Feb 5, 2021

ghost commented Mar 7, 2021

grahamjenson commented Mar 4, 2020 •

edited

Loading

divmgl left a comment •

edited

Loading