Disallow empty filter block on aws_s3_bucket_metric resource

[gdavison]

The resource aws_s3_bucket_metric currently allows an empty filter block, which is meaningless, as it creates no filter.

When a filter is supplied, at least one of prefix or tags should be required.

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Affected Resource(s)

• aws_s3_bucket_metric

Terraform Configuration Files

This example should not be valid, since it is equivalent to not supplying a filter at all.

resource "aws_s3_bucket_metric" "test" {
  bucket = aws_s3_bucket.test.id
  name   = "%s"
  filter {}
}

[anGie44]

The change in #14230 has been merged and will release with the upcoming v3.0.0 of the Provider.

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!