-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding IAM SAML Provider Data source #10498
Conversation
Notification of Recent and Upcoming Changes to ContributionsThank you for this contribution! There have been a few recent development changes that affect this pull request. We apologize for the inconvenience, especially if there have been long review delays up until now. Please note that this is automated message from an unmonitored account. See the FAQ for additional information on the maintainer team and review prioritization. If you are unable to complete these updates, please leave a comment for the community and maintainers so someone can potentially continue the work. The maintainers will encourage other contributors to use the existing contribution as the base for additional changes as appropriate. Otherwise, contributions that do not receive updated code or comments from the original contributor may be closed in the future so the maintainers can focus on active items. For the most up to date information about Terraform AWS Provider development, see the Contributing Guide. Additional technical debt changes can be tracked with the As part of updating a pull request with these changes, the most current unit testing and linting will run. These may report issues that were not previously reported. Action Required: Terraform 0.12 SyntaxReference: #8950 Version 3 and later of the Terraform AWS Provider, which all existing contributions would potentially be added, only supports Terraform 0.12 and later. Certain syntax elements of Terraform 0.11 and earlier show deprecation warnings during runs with Terraform 0.12. Documentation and test configurations, such as those including deprecated string interpolations ( Action Required: Terraform Plugin SDK Version 2Reference: #14551 The Terraform AWS Provider has been upgraded to the latest version of the Terraform Plugin SDK. Generally, most changes to contributions should only involve updating Go import paths in source code files. Please see the referenced issue for additional information. Action Required: Removal of website/aws.erb FileReference: #14712 Any changes to the Upcoming Change of Git Branch NamingReference: #14292 Development environments will need their upstream Git branch updated from Upcoming Change of GitHub OrganizationReference: #14715 This repository will be migrating from https://github.com/terraform-providers/terraform-provider-aws to https://github.com/hashicorp/terraform-provider-aws. No practitioner or developer action is anticipated and most GitHub functionality will automatically redirect to the new location. Go import paths including |
Hey @alpacamybags118 , just found this PR for this data source that I'm looking to use, and glad someone has already started the work for it. It seems like it went stale, and there is a bunch of changes required to it to bring it up to meet the Plugin SDK v2 (and other) requirements listed above. Is this something you might have time to do, if not I'm more than happy to do it. Your work so far would be hugely helpful in doing so. Just want to make sure you get credit for the initial changes and a chance to update it if you wanted to. |
@yzguy thanks for bringing this back up. I honestly totally forgot about this PR after so much time! I'll take a look at this over the weekend to see if i can migrate it to the updated format. |
68209e1
to
a5d6511
Compare
a5d6511
to
ce326e9
Compare
528e4a5
to
1d70cbc
Compare
fe5e9ea
to
2d4117d
Compare
Rebased to keep this PR up to date. Would there be any chance this could be reviewed @ewbankkit ? Thank you! |
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
This reverts commit 8832940.
This reverts commit 2d4117d.
This reverts commit bbeb5a5.
This reverts commit 3471e9a.
This reverts commit 557351e.
…eout CRUD handler signatures (hashicorp#15090).
…sts. Acceptance test output: % make testacc TESTS=TestAccIAMSAMLProvider_ PKG=iam ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMSAMLProvider_' -timeout 180m === RUN TestAccIAMSAMLProvider_basic === PAUSE TestAccIAMSAMLProvider_basic === RUN TestAccIAMSAMLProvider_tags === PAUSE TestAccIAMSAMLProvider_tags === RUN TestAccIAMSAMLProvider_disappears === PAUSE TestAccIAMSAMLProvider_disappears === CONT TestAccIAMSAMLProvider_basic === CONT TestAccIAMSAMLProvider_disappears === CONT TestAccIAMSAMLProvider_tags --- PASS: TestAccIAMSAMLProvider_disappears (13.02s) --- PASS: TestAccIAMSAMLProvider_basic (26.69s) --- PASS: TestAccIAMSAMLProvider_tags (35.63s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 39.482s
Acceptance test output: % make testacc TESTS=TestAccIAMSAMLProviderDataSource_basic PKG=iam ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 20 -run='TestAccIAMSAMLProviderDataSource_basic' -timeout 180m === RUN TestAccIAMSAMLProviderDataSource_basic === PAUSE TestAccIAMSAMLProviderDataSource_basic === CONT TestAccIAMSAMLProviderDataSource_basic --- PASS: TestAccIAMSAMLProviderDataSource_basic (13.81s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 17.988s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccIAMSAMLProvider PKG=iam ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iam/... -v -count 1 -parallel 3 -run='TestAccIAMSAMLProvider' -timeout 180m
=== RUN TestAccIAMSAMLProviderDataSource_basic
=== PAUSE TestAccIAMSAMLProviderDataSource_basic
=== RUN TestAccIAMSAMLProvider_basic
=== PAUSE TestAccIAMSAMLProvider_basic
=== RUN TestAccIAMSAMLProvider_tags
=== PAUSE TestAccIAMSAMLProvider_tags
=== RUN TestAccIAMSAMLProvider_disappears
=== PAUSE TestAccIAMSAMLProvider_disappears
=== CONT TestAccIAMSAMLProviderDataSource_basic
=== CONT TestAccIAMSAMLProvider_tags
=== CONT TestAccIAMSAMLProvider_disappears
--- PASS: TestAccIAMSAMLProvider_disappears (12.90s)
=== CONT TestAccIAMSAMLProvider_basic
--- PASS: TestAccIAMSAMLProviderDataSource_basic (15.13s)
--- PASS: TestAccIAMSAMLProvider_tags (37.24s)
--- PASS: TestAccIAMSAMLProvider_basic (24.46s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iam 41.675s
This functionality has been released in v4.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #7283
Release note for CHANGELOG:
Output from acceptance testing:
The scenarios for using this would the following: