internal: Implement fwserver PlanResourceChange testing and update proto6server testing (#367)

Reference: #215

Also removes the placeholder `internal/testing/emptyprovider` implementation in preference of the fully built out declarative one in `internal/testing/testprovider`.

At this point we should hopefully feel pretty confident in the framework and protocol version 6 server unit testing focusing on their logic and data handoffs to other functions/methods. This also means we should be in a good spot to create a protocol version 5 implementation, very similar to the protocol version 6 implementation.

Author: bflad

internal/fwserver/attribute_plan_modification.go

@@ -14,7 +14,7 @@ import (
 // TODO: Clean up this abstraction back into an internal Attribute type method.
 // The extra Attribute parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func AttributeModifyPlan(ctx context.Context, a tfsdk.Attribute, req tfsdk.ModifyAttributePlanRequest, resp *ModifySchemaPlanResponse) {
 	ctx = logging.FrameworkWithAttributePath(ctx, req.AttributePath.String())
 

internal/fwserver/attribute_validation.go

@@ -14,7 +14,7 @@ import (
 // TODO: Clean up this abstraction back into an internal Attribute type method.
 // The extra Attribute parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func AttributeValidate(ctx context.Context, a tfsdk.Attribute, req tfsdk.ValidateAttributeRequest, resp *tfsdk.ValidateAttributeResponse) {
 	ctx = logging.FrameworkWithAttributePath(ctx, req.AttributePath.String())
 
@@ -104,7 +104,7 @@ func AttributeValidate(ctx context.Context, a tfsdk.Attribute, req tfsdk.Validat
 // TODO: Clean up this abstraction back into an internal Attribute type method.
 // The extra Attribute parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func AttributeValidateNestedAttributes(ctx context.Context, a tfsdk.Attribute, req tfsdk.ValidateAttributeRequest, resp *tfsdk.ValidateAttributeResponse) {
 	if a.Attributes == nil || len(a.Attributes.GetAttributes()) == 0 {
 		return

internal/fwserver/block_plan_modification.go

@@ -13,7 +13,7 @@ import (
 // TODO: Clean up this abstraction back into an internal Block type method.
 // The extra Block parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func BlockModifyPlan(ctx context.Context, b tfsdk.Block, req tfsdk.ModifyAttributePlanRequest, resp *ModifySchemaPlanResponse) {
 	attributeConfig, diags := ConfigGetAttributeValue(ctx, req.Config, req.AttributePath)
 	resp.Diagnostics.Append(diags...)

internal/fwserver/block_validation.go

@@ -13,7 +13,7 @@ import (
 // TODO: Clean up this abstraction back into an internal Block type method.
 // The extra Block parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func BlockValidate(ctx context.Context, b tfsdk.Block, req tfsdk.ValidateAttributeRequest, resp *tfsdk.ValidateAttributeResponse) {
 	attributeConfig, diags := ConfigGetAttributeValue(ctx, req.Config, req.AttributePath)
 	resp.Diagnostics.Append(diags...)

internal/fwserver/config.go

@@ -21,7 +21,7 @@ import (
 // TODO: Clean up this abstraction back into an internal Config type method.
 // The extra Config parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/366
 func ConfigGetAttributeValue(ctx context.Context, c tfsdk.Config, path *tftypes.AttributePath) (attr.Value, diag.Diagnostics) {
 	var diags diag.Diagnostics
 
@@ -88,7 +88,7 @@ func ConfigGetAttributeValue(ctx context.Context, c tfsdk.Config, path *tftypes.
 // TODO: Clean up this abstraction back into an internal Config type method.
 // The extra Config parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/366
 func ConfigTerraformValueAtPath(c tfsdk.Config, path *tftypes.AttributePath) (tftypes.Value, error) {
 	rawValue, remaining, err := tftypes.WalkAttributePath(c.Raw, path)
 	if err != nil {

internal/fwserver/plan.go

@@ -21,7 +21,7 @@ import (
 // TODO: Clean up this abstraction back into an internal Plan type method.
 // The extra Plan parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/366
 func PlanGetAttributeValue(ctx context.Context, p tfsdk.Plan, path *tftypes.AttributePath) (attr.Value, diag.Diagnostics) {
 	var diags diag.Diagnostics
 
@@ -88,7 +88,7 @@ func PlanGetAttributeValue(ctx context.Context, p tfsdk.Plan, path *tftypes.Attr
 // TODO: Clean up this abstraction back into an internal Plan type method.
 // The extra Plan parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/366
 func PlanTerraformValueAtPath(p tfsdk.Plan, path *tftypes.AttributePath) (tftypes.Value, error) {
 	rawValue, remaining, err := tftypes.WalkAttributePath(p.Raw, path)
 	if err != nil {

internal/fwserver/schema.go

@@ -14,7 +14,7 @@ import (
 // TODO: Clean up this abstraction back into an internal Schema type method.
 // The extra Schema parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func SchemaBlockAtPath(s tfsdk.Schema, path *tftypes.AttributePath) (tfsdk.Block, error) {
 	res, remaining, err := tftypes.WalkAttributePath(s, path)
 	if err != nil {

internal/fwserver/schema_plan_modification.go

@@ -47,7 +47,7 @@ type ModifySchemaPlanResponse struct {
 // TODO: Clean up this abstraction back into an internal Schema type method.
 // The extra Schema parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func SchemaModifyPlan(ctx context.Context, s tfsdk.Schema, req ModifySchemaPlanRequest, resp *ModifySchemaPlanResponse) {
 	for name, attr := range s.Attributes {
 		attrReq := tfsdk.ModifyAttributePlanRequest{

internal/fwserver/schema_validation.go

@@ -31,7 +31,7 @@ type ValidateSchemaResponse struct {
 // TODO: Clean up this abstraction back into an internal Schema type method.
 // The extra Schema parameter is a carry-over of creating the proto6server
 // package from the tfsdk package and not wanting to export the method.
-// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/215
+// Reference: https://github.com/hashicorp/terraform-plugin-framework/issues/365
 func SchemaValidate(ctx context.Context, s tfsdk.Schema, req ValidateSchemaRequest, resp *ValidateSchemaResponse) {
 	for name, attribute := range s.Attributes {