Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rootmodules custom command #515

Closed
radeksimko opened this issue May 18, 2021 · 2 comments · Fixed by #846
Closed

Deprecate rootmodules custom command #515

radeksimko opened this issue May 18, 2021 · 2 comments · Fixed by #846
Assignees
Labels
modules Functionality related to the module block and modules generally technical-debt
Milestone

Comments

@radeksimko
Copy link
Member

Current Version

0.16.2

Use-cases

As described in #507 this command was succeeded by module.callers. The new command has much narrower scope and more appropriate name.

Proposal

It is proposed to deprecate the existing rootmodules command in favour of module.callers. Ideally clients (including the VS Code extension) should ask the server whether it supports certain commands before attempting to execute them, but I'm unsure whether this LSP convention is being followed.

Given that this command was historically used to "just" improve the UI, I'm thinking that returning error on execution should only mean that users are forced to type out module paths more often, but it shouldn't block anyone.

@github-actions
Copy link

This functionality has been released in v0.27.0 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
modules Functionality related to the module block and modules generally technical-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant