Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple languageserver instances will crash on vscode #278

Closed
appilon opened this issue Oct 21, 2020 · 1 comment · Fixed by #279
Closed

Multiple languageserver instances will crash on vscode #278

appilon opened this issue Oct 21, 2020 · 1 comment · Fixed by #279
Labels
bug Something isn't working

Comments

@appilon
Copy link
Contributor

appilon commented Oct 21, 2020 •
edited
Loading

The recently merged #274 will crash on vscode (tested), it seems to hit the exact case here

microsoft/vscode-languageserver-node#333

screengrab

Screen Shot 2020-10-21 at 3 51 18 PM

One reply suggests doing something to ensure command uniqueness between server instances, but that is really disappointing and feels like a hack.
@appilon appilon added bug Something isn't working lsp labels Oct 21, 2020
@appilon appilon mentioned this issue Oct 23, 2020
Merged
@ghost
Copy link

ghost commented Nov 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unique command names hashicorp/terraform-ls
1 participant
@appilon