Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement textDocument/didSave #21

Closed
radeksimko opened this issue Mar 6, 2020 · 2 comments
Closed

Implement textDocument/didSave #21

radeksimko opened this issue Mar 6, 2020 · 2 comments
Labels
text-synchronization https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocum

Comments

@radeksimko
Copy link
Member

It appears the LSP spec doesn't allow for this method to be disabled via capabilities, which means it's probably required (?), so we should implement it: https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_didSave

@radeksimko radeksimko added this to the v0.2.0 milestone Mar 30, 2020
@radeksimko radeksimko removed this from the v0.2.0 milestone Apr 22, 2020
@radeksimko radeksimko added text-synchronization https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocum and removed lsp-compliance labels May 12, 2020
@radeksimko radeksimko added the lsp label Jul 29, 2020
@radeksimko
Copy link
Member Author

This was practically implemented as part of #336 although the validation is opt-in.

@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
text-synchronization https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocum
Projects
None yet
Development

No branches or pull requests

1 participant