Trim trailing slash from rootUri on initialize

[radeksimko]

Server Version

v0.4.0

Client Version

IntelliJ LSP Support 1.6.1

Terraform Configuration Files

provider "aws" {

}

Log Output

The IntelliJ extension seems to be sending trailing slash with the rootUri in the initalize request:

2020/07/03 10:32:26 server.go:223: Checking request for "initialize": {"processId":null,"rootUri":"file:///private/var/workspace/tf-test/github/","capabilities":{"workspace":{"applyEdit":true,"workspaceEdit":{"documentChanges":true},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"symbol":{},"executeCommand":{},"workspaceFolders":false,"configuration":true},"textDocument":{"synchronization":{"willSave":true,"willSaveWaitUntil":true,"didSave":true},"completion":{"completionItem":{"snippetSupport":true}},"hover":{},"signatureHelp":{},"references":{},"documentHighlight":{},"formatting":{},"rangeFormatting":{},"onTypeFormatting":{},"definition":{},"codeAction":{},"rename":{"prepareSupport":true,"dynamicRegistration":false},"semanticHighlightingCapabilities":{"semanticHighlighting":false}}}}

which then makes the server believe that /private/var/workspace/tf-test/github/ is not the same as /private/var/workspace/tf-test/github.

Expected Behavior

Root module to be found

Actual Behavior

Arguably that message shouldn't be presented like this since it's a warning, not an error, but that's something to fix on the client side.

Steps to Reproduce

1. terraform init the folder with the above config
2. Open a folder with the above config
3. Open the above file from that folder

[radeksimko]

This seems to be already happening

terraform-ls/internal/lsp/file_handler.go

Lines 17 to 20 in bf57c3e

	// Dir URIs are usually without trailing separator already
	// but we do sanity check anyway, so we deal with the same URI
	// regardless of language client differences
	uri := strings.TrimSuffix(string(dirUri), "/")

also I'm unsure why, but the bug is not reproducible after the refactoring in #219 so I'm assuming #219 solves it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.