Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textDocument/complete: Complete resource+datasource names #19

Closed
radeksimko opened this issue Mar 6, 2020 · 2 comments · Fixed by #58
Closed

textDocument/complete: Complete resource+datasource names #19

radeksimko opened this issue Mar 6, 2020 · 2 comments · Fixed by #58
Assignees
Milestone

Comments

@radeksimko
Copy link
Member

Until hashicorp/terraform#24261 is resolved we'd only be able to complete resource names of providers which are already declared in the config.

That seems like a reasonable temporary limitation though, so it's still worth implementing even without hashicorp/terraform#24261

Example

provider "aws" {
  region = "us-west-2"
}

resource "<HERE>" "" {

}

We should also decide out whether/how to complete incomplete declarations, such as

provider "aws" {
  region = "us-west-2"
}

resource "<HERE>

I'm not sure how HCL parser behaves in this case ^

@radeksimko radeksimko added this to the v0.2.0 milestone Mar 24, 2020
@radeksimko radeksimko self-assigned this Apr 20, 2020
@radeksimko radeksimko changed the title textDocument/complete: Complete resource names textDocument/complete: Complete resource+datasource names Apr 21, 2020
@radeksimko
Copy link
Member Author

Completing incomplete declarations is tracked under #57

@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant