Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use stacks schema merger #1770

Merged
merged 7 commits into from
Jul 30, 2024
Merged

feat: use stacks schema merger #1770

merged 7 commits into from
Jul 30, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Jul 18, 2024

Merge all the schemas (for stacks stack files) 💯

This brings support for completions for inputs and providers in component blocks and for showing descriptions on hover among other schema related features. Note: this currently only supports local components with a source in a relative directory.

@ansgarm ansgarm changed the title wip feat: use stacks schema merger Jul 18, 2024
@ansgarm ansgarm force-pushed the stacks-merge-schemas branch 2 times, most recently from a8d7806 to 5676649 Compare July 23, 2024 08:26
@ansgarm ansgarm force-pushed the stacks-merge-schemas branch 3 times, most recently from 3d75cae to 5ccc168 Compare July 25, 2024 14:34
@ansgarm ansgarm marked this pull request as ready for review July 25, 2024 14:39
@ansgarm ansgarm requested a review from a team as a code owner July 25, 2024 14:39
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some suggestions

internal/features/stacks/state/stack_store.go Outdated Show resolved Hide resolved
internal/features/stacks/events.go Outdated Show resolved Hide resolved
internal/features/stacks/events.go Outdated Show resolved Hide resolved
internal/features/stacks/decoder/path_reader.go Outdated Show resolved Hide resolved
@ansgarm ansgarm requested a review from dbanck July 30, 2024 08:31
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback

@ansgarm ansgarm merged commit 1ca689b into pre-release Jul 30, 2024
6 checks passed
@ansgarm ansgarm deleted the stacks-merge-schemas branch July 30, 2024 12:43
jpogran pushed a commit that referenced this pull request Aug 7, 2024
* chore: make provider schema available to schema merger
* refactor: move PreloadEmbeddedSchema job into Defer as future jobs in Defer will depend on it
* feat: make module meta available in schema merger
* chore: add changie entry
* fix: combine readers into one, address review feedback
* refactor: continue parsing if loading stack component sources failed
* Bump terraform-schema to `9fc1ce5`
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants