(TF-18292) Load Stack component sources from metadata #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
changed the title
jpogran
force-pushed
the
load_stack_component_sources
branch
from
a358aea
to
cad3dd9
Compare
ansgarm
force-pushed
the
load_stack_component_sources
branch
from
619becd
to
f2c9255
Compare
This change adds a new job to load the component sources of a stack after parsing the stack metadata. For a component with a module source, the job will trigger a `did_open` event for the Modules feature to handle. This will allow the Modules feature to load the module and its dependencies, leading to eventually being able to complete Module references. This only handles local modules at the moment. Remote modules are not supported yet.
…allow jobs to wait for kicked-off events to settle Use this new functionality in LoadStackComponentSources to allow waiting for parsing local modules used in stacks components before other jobs run that need the parsing results
…de, use DoneChannel type in more places
jpogran
force-pushed
the
load_stack_component_sources
branch
from
a85d247
to
a74d55a
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new job to load the component sources of a stack after parsing the stack metadata. For a component with a module source, the job will trigger a
did_openevent for the Modules feature to handle. This will allow the Modules feature to load the module and its dependencies, leading to eventually being able to complete Module references.This only handles local modules at the moment. Remote modules are not supported yet.
Needs hashicorp/terraform-schema#374 to parse module source addresses.