Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TF-18286) Add jobs to load Stack metadata #1761

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jul 11, 2024

This commit adds a job to load the metadata for a stack. This metadata is used to decode the some of the configuration early before we have all the information we need to decode the full configuration. This is a first step towards decoding the full configuration of a stack.

@jpogran jpogran self-assigned this Jul 11, 2024
@jpogran jpogran changed the title Add jobs to load Stack metadata (TF-18286) Add jobs to load Stack metadata Jul 11, 2024
Base automatically changed from pre-release to main July 15, 2024 10:31
This commit adds a job to load the metadata for a stack. This metadata is used to decode the some of the configuration early before we have all the information we need to decode the full configuration. This is a first step towards decoding the full configuration of a stack.
@jpogran jpogran changed the base branch from main to pre-release July 16, 2024 13:46
@jpogran jpogran marked this pull request as ready for review July 16, 2024 14:15
@jpogran jpogran requested a review from a team as a code owner July 16, 2024 14:15
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I left some small suggestions

internal/features/stacks/events.go Outdated Show resolved Hide resolved
internal/features/stacks/state/stack_meta.go Outdated Show resolved Hide resolved
internal/features/stacks/state/stack_meta.go Show resolved Hide resolved
internal/features/stacks/state/stack_store.go Outdated Show resolved Hide resolved
internal/features/stacks/ast/stacks.go Show resolved Hide resolved
internal/features/stacks/jobs/metadata.go Outdated Show resolved Hide resolved
internal/features/stacks/jobs/metadata.go Outdated Show resolved Hide resolved
@jpogran jpogran requested a review from dbanck July 16, 2024 15:04
@jpogran jpogran merged commit 03af364 into pre-release Jul 16, 2024
6 checks passed
@jpogran jpogran deleted the stacks_metadata branch July 16, 2024 16:24
jpogran added a commit that referenced this pull request Aug 7, 2024
This commit adds a job to load the metadata for a stack. This metadata is used to decode the some of the configuration early before we have all the information we need to decode the full configuration. This is a first step towards decoding the full configuration of a stack.
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants