Decode declared modules for all kind of installed modules #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new map based on the content of the module manifest. We can use the map to look up local installation paths based on the module source.
We now can look up their installation path based on the normalized module source. We avoid decoding the whole `.terraform` directory by only looking at modules that are used in the configuration.
dbanck
force-pushed
the
f-decode-installed-modules
branch
from
cafaa8f
to
3bcfe84
Compare
ansgarm
approved these changes
Jul 11, 2024
dbanck
force-pushed
the
f-decode-installed-modules
branch
from
3bcfe84
to
27d6fd1
Compare
1 task
This was referenced Jul 19, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing piece from #1667: decoding declared module calls for locally installed modules (inside the
.terraform/directory)We do this by normalizing the value of the
sourceattribute and matching it against entries in the module manifest. If we find a matching entry, we decode the contents of the folder.This not only re-enables it for registry modules, but also takes the approach a step further, allowing completion for (almost) any locally installed remote module (including submodules!).
UX After