Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report progress when obtaining schema #150

Closed
radeksimko opened this issue Jun 10, 2020 · 2 comments
Closed

Report progress when obtaining schema #150

radeksimko opened this issue Jun 10, 2020 · 2 comments
Labels

Comments

@radeksimko
Copy link
Member

Current Version

0.3.2

Use-cases

The language server has to obtain schema in order to have data for completion candidates and other features from whatever providers the user has in their configuration.

This currently happens literally behind the scenes, asynchronously, without the user knowing, which means the user isn't literally "blocked" while we're obtaining schema, but it does lead to a suboptimal UX:

  1. user requests completion at pos line:col
  2. server responds with no candidates and error "schema temporarily unavailable"
  3. client caches this "no candidates" response
  4. user retries few seconds later, when schema is available, but still gets "no candidates", because that's what's in cache, so client doesn't ask again for the same position, until the file is changed

Generally the user expects to be able to get completion straight away and it's not obvious why they aren't able to get it, or what the error ("schema temporarily unavailable") could mean and when they could retry.

Proposal

Report progress while obtaining schema to the client/UI to better inform the user when this background operation is running and when they could expect completion to work.

Related LSP methods

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#window_workDoneProgress_create

https://microsoft.github.io/language-server-protocol/specifications/specification-current/#window_workDoneProgress_cancel

@radeksimko
Copy link
Member Author

Closing in favour of #5 which now tracks progress reporting for the major time-consuming operations.

@radeksimko radeksimko closed this as not planned Won't fix, can't repro, duplicate, stale Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant