Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go-to-definition/go-to-references for count.index/count #1093

Closed
radeksimko opened this issue Oct 20, 2022 · 1 comment · Fixed by #1115
Closed

Go-to-definition/go-to-references for count.index/count #1093

radeksimko opened this issue Oct 20, 2022 · 1 comment · Fixed by #1115

Comments

@radeksimko
Copy link
Member

Background

As part of implementing #860 in hashicorp/hcl-lang#134 we took a shortcut and decided not to treat count.index as an actual reference origin and similarly not treat count attribute as a target.

This has some implications on the UX and some future work

Go To Definition

While the benefit isn't as obvious in a simple and short config, there are cases where a module or a resource may not fit on the screen. Secondly, as a user I'd just expect "go-to-definition" to always work for any reference, if that reference points somewhere in the code.

196968992-fb23e265-4d62-44ec-8034-064a6bf95f16

Go To References

Similar as above, there can be a number of count.index references and it would be reasonable to expect "go-to-references" to just work in that context.

Screenshot 2022-10-20 at 15 06 23

Config Resolution

There are features which will rely on our ability to resolve references within the config, for example:

Proposal

TODO

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants