Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: Gate formatting command on 0.7.7 #88

Merged
merged 3 commits into from
Sep 25, 2020
Merged

fmt: Gate formatting command on 0.7.7 #88

merged 3 commits into from
Sep 25, 2020

Conversation

radeksimko
Copy link
Member

This is mostly a UX enhancement which is already built into LS, so this is to help ease the transition.

@radeksimko radeksimko mentioned this pull request Sep 24, 2020
Closed
@radeksimko
Copy link
Member Author

radeksimko commented Sep 24, 2020 •
edited
Loading

I'm not sure what's causing the failures in 1.14 and 1.15 (#89), but I'm pretty sure it's unrelated to this PR as I can reproduce it on master.

paultyng
paultyng reviewed Sep 24, 2020
View reviewed changes
tfexec/errors.go Outdated Show resolved Hide resolved
paultyng
paultyng reviewed Sep 25, 2020
View reviewed changes
tfexec/errors.go Outdated Show resolved Hide resolved
@paultyng
Copy link
Contributor

LGTM, but I think that Is function is unnecessary as its equivalent to the built-in code.

@radeksimko radeksimko merged commit 9c73b81 into master Sep 25, 2020
@radeksimko radeksimko deleted the gate-fmt-on-0.7.7 branch September 25, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @paultyng