Add support for metadata functions -json command
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
changed the title
metadata functions -json command,metadata functions -json command
dbanck
force-pushed
the
f-metadata-functions
branch
from
82a097e
to
252f514
Compare
Relative paths in the go.work file are likely machine specific and won't work on other systems.
dbanck
force-pushed
the
f-metadata-functions
branch
from
252f514
to
d449928
Compare
3 tasks
radeksimko
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Confirming that the output is coming through in the E2E test: https://github.com/hashicorp/terraform-exec/actions/runs/4176231939/jobs/7232437983#step:4:913
👍🏻 LGTM 
Co-authored-by: Radek Simko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
terraform metadata functions -jsoncommand, which was introduced in hashicorp/terraform#32487. We need this to obtain the function signatures within terraform-ls.Depends on:
TODO
That might require the Terraform 1.4 releaseIt's working formainhttps://github.com/hashicorp/terraform-exec/actions/runs/4176231939/jobs/7232445810#step:4:910