Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]new plugin googlecompute machine image #188

Open
lmayorga1980 opened this issue Oct 5, 2023 · 1 comment
Open

[feature]new plugin googlecompute machine image #188

lmayorga1980 opened this issue Oct 5, 2023 · 1 comment
Labels

Comments

@lmayorga1980
Copy link
Contributor

lmayorga1980 commented Oct 5, 2023

I would like to contribute to this repo by creating an machine image gcp resource, basically is a clone of googlecompute but instead of saving as another gcp image, it will be saved as machine image.

https://cloud.google.com/compute/docs/machine-images

Should i start creating another builder called googlecomputemachineimage?

The process will be basically the following:

  1. Use the CreateImage part of the code to create a google compute instance and run provisioners.
  2. Create the machine image based on the running google compute instance.
  3. Delete the running instance.

The other option would be to extend the current googlecompute builder and add a conditional to create the machine image create_machine_image and the steps will basically create a new machine image and teardown the instance afterwards without creating a real gcp image.

@lmayorga1980 lmayorga1980 changed the title [feature]googlecompute instance template [feature]googlecompute machine image Oct 5, 2023
@lmayorga1980 lmayorga1980 changed the title [feature]googlecompute machine image [feature]new plugin googlecompute machine image Oct 8, 2023
@lmayorga1980
Copy link
Contributor Author

Hi @nywilken ,

What would be your suggestion in order to support machine-images for google compute. Maybe a forked repo and keeping it up to date with the latest changes. The feature reuses most of the work already done by the regular google image golang code but I understand why it cannot be merged.

Please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant