Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Unify how we detect abort errors #9944

Open
DingoEatingFuzz opened this issue Feb 2, 2021 · 0 comments
Open

UI: Unify how we detect abort errors #9944

DingoEatingFuzz opened this issue Feb 2, 2021 · 0 comments

Comments

@DingoEatingFuzz
Copy link
Contributor

As part of the Ember 3.20 and related dependency upgrades, the existing error instanceof AbortError check became insufficient.

With some research, I think we can find a new way to handle this issue with a single conditional.

const signal = get(snapshot || {}, 'adapterOptions.abortController.signal');
return this.ajax(url, 'GET', {
signal,
data: params,
}).catch(error => {
if (error instanceof AbortError || error.name == 'AbortError') {
return;
}
throw error;
});
}

Introduced in #9912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant