Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI enhancement for disabling periodic jobs and improve state visibility #19671

Closed
dmclf opened this issue Jan 9, 2024 · 3 comments
Closed

UI enhancement for disabling periodic jobs and improve state visibility #19671

dmclf opened this issue Jan 9, 2024 · 3 comments
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/periodic theme/ui type/enhancement

Comments

@dmclf
Copy link

dmclf commented Jan 9, 2024

Proposal

Periodic jobs now have an enabled flag
Would it not be more convenient if this:

  1. is a simple button on the UI, like stop, but then disable
  2. UI to be improved and clearly mark a job as disabled
  • now, when you disable a job it is still marked as 'running'
    image
    even though the enabled is false, which may not visually match expectations.
  1. additionally, can this state also be exported to the prometheus metrics, so it is also easy to make monitoring/alerting on disabled jobs if people would desire/require?

Use-cases

More simplified way to disable a job, with better visibility.
(also suits cases where some people that may not feel comfortable editing raw jobspecs, would still be able to disable a job)

@jrasell jrasell added theme/ui stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/periodic labels Jan 9, 2024
@jrasell
Copy link
Member

jrasell commented Jan 9, 2024

Hi @dmclf and thanks for raising this issue. I think it makes sense to have a way to show if a periodic job is disabled or not within the UI, therefore I have pass this over to our UI engineer who will be able to better understand the request for roadmapping.

@philrenaud
Copy link
Contributor

@dmclf a great idea, and thank you for the suggestion. We'll work on making this easier to surface/toggle via the UI.

@philrenaud philrenaud self-assigned this Jan 24, 2024
@philrenaud
Copy link
Contributor

@dmclf I gave this some thought and put together an experiment with it this afternoon, and the end result is I've opted away from it. I wanted to explain about why:

  • The "stop" and "start" nomenclature matches how we use job commands on the CLI and the property of our http API
  • The "Stop" / "Are you sure" / "Start" buttons would deviate from other non-periodic jobs if we changed them up here, requiring users to become familiar with another pattern.

As such, I don't think this is worth doing. I thank you for raising this issue and for the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/periodic theme/ui type/enhancement
Projects
Status: Done
Development

No branches or pull requests

3 participants