job_endpoint: check spec for all regions #14519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekStrickland
added
backport/1.1.x
tgross
requested changes
Sep 9, 2022
There was a problem hiding this comment.
I think the overall approach here is sound @DerekStrickland
DerekStrickland
added a commit
that referenced
this pull request
Sep 12, 2022
* job_endpoint: check spec for all regions
DerekStrickland
added a commit
that referenced
this pull request
Sep 12, 2022
* job_endpoint: check spec for all regions Co-authored-by: Derek Strickland <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a helper method to the Job RPC endpoint called specChanged. This method checks whether an incoming jobspec has changed relative to the currently deployed jobspec in all regions. This handles the case where a job has been stopped in one or more regions, and the operator now wants to restart it. By checking all regions, the spec change is detected, and a new job version can be computed and deployed to all multiregion targets.