fix errcheck lint errors and run it as part of pr checks

Author: Abhijeet V

.github/workflows/go-getter.yml

@@ -22,14 +22,14 @@ jobs:
         uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
         with:
           go-version: ${{ matrix.go-version }}
-      
+
       - name: Checkout code
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
 
       - name: Create test directory
         run: |
           mkdir -p ${{ env.TEST_RESULTS_PATH }}
-  
+
       - name: Setup cache for go modules
         uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
         with:
@@ -39,10 +39,10 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
-      
+
       - name: Download go modules
         run: go mod download
-      
+
       # Check go fmt output because it does not report non-zero when there are fmt changes
       - name: Run gofmt
         run: |
@@ -53,7 +53,7 @@ jobs:
               echo "$files"
               exit 1
             fi
-      
+
       - name: Install gotestsum
         run: go install gotest.tools/[email protected]
 
@@ -71,14 +71,14 @@ jobs:
           workload_identity_provider: 'projects/328212837253/locations/global/workloadIdentityPools/hc-go-getter-test/providers/github-hc-go-getter-test'
           service_account: hc-go-getter-test@hc-e56c0f7c21c448d2be9e7696073.iam.gserviceaccount.com
           audience: https://github.com/hashicorp
-        
+
       - name: Run go tests
         run: |
           PACKAGE_NAMES=$(go list ./...)
           echo "Running $(echo $PACKAGE_NAMES | wc -w) packages"
           echo $PACKAGE_NAMES
           gotestsum --format=short-verbose --junitfile $TEST_RESULTS_PATH/go-getter/gotestsum-report.xml -- -p 2 -cover -coverprofile=linux_cov.part $PACKAGE_NAMES
-      
+
       # Save coverage report parts
       - name: Upload and save artifacts
         uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
@@ -104,7 +104,7 @@ jobs:
         uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0
         with:
           go-version: ${{ matrix.go-version }}
-      
+
       - name: Checkout code
         uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
 
@@ -120,11 +120,11 @@ jobs:
 
       - name: Download go modules
         run: go mod download
-       
+
       - name: Install gotestsum
         shell: bash
         run: go install gotest.tools/[email protected]
-        
+
       - name: Configure AWS Credentials
         uses: aws-actions/configure-aws-credentials@8c3f20df09ac63af7b3ae3d7c91f105f857d8497 # v4.0.0
         with:
@@ -139,18 +139,28 @@ jobs:
           workload_identity_provider: 'projects/328212837253/locations/global/workloadIdentityPools/hc-go-getter-test/providers/github-hc-go-getter-test'
           service_account: hc-go-getter-test@hc-e56c0f7c21c448d2be9e7696073.iam.gserviceaccount.com
           audience: https://github.com/hashicorp
-      
+
       - name: Run go tests
         shell: bash
         run: |
           PACKAGE_NAMES=$(go list ./...)
           echo "Running $(echo $PACKAGE_NAMES | wc -w) packages"
           echo $PACKAGE_NAMES
           gotestsum --format=short-verbose --junitfile $TEST_RESULTS_PATH/go-getter/gotestsum-report.xml -- -p 2 -cover -race -coverprofile=win_cov.part $PACKAGE_NAMES
-      
+
       # Save coverage report parts
       - name: Upload and save artifacts
         uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808
         with:
           name: windows-test-results-${{ matrix.go-version }}
-          path: win_cov.part
+          path: win_cov.part
+
+  linter:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
+      - name: Lint code
+        uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
+        with:
+          args: --enable-only errcheck # this is temporary until the other lint errors are fixed

checksum.go

@@ -58,7 +58,7 @@ func (c *FileChecksum) checksum(source string) error {
 	if err != nil {
 		return fmt.Errorf("Failed to open file for checksum: %s", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	c.Hash.Reset()
 	if _, err := io.Copy(c.Hash, f); err != nil {
@@ -80,20 +80,24 @@ func (c *FileChecksum) checksum(source string) error {
 // extractChecksum will return a FileChecksum based on the 'checksum'
 // parameter of u.
 // ex:
-//  http://hashicorp.com/terraform?checksum=<checksumValue>
-//  http://hashicorp.com/terraform?checksum=<checksumType>:<checksumValue>
-//  http://hashicorp.com/terraform?checksum=file:<checksum_url>
+//
+//	http://hashicorp.com/terraform?checksum=<checksumValue>
+//	http://hashicorp.com/terraform?checksum=<checksumType>:<checksumValue>
+//	http://hashicorp.com/terraform?checksum=file:<checksum_url>
+//
 // when checksumming from a file, extractChecksum will go get checksum_url
 // in a temporary directory, parse the content of the file then delete it.
 // Content of files are expected to be BSD style or GNU style.
 //
 // BSD-style checksum:
-//  MD5 (file1) = <checksum>
-//  MD5 (file2) = <checksum>
+//
+//	MD5 (file1) = <checksum>
+//	MD5 (file2) = <checksum>
 //
 // GNU-style:
-//  <checksum>  file1
-//  <checksum> *file2
+//
+//	<checksum>  file1
+//	<checksum> *file2
 //
 // see parseChecksumLine for more detail on checksum file parsing
 func (c *Client) extractChecksum(u *url.URL) (*FileChecksum, error) {
@@ -203,7 +207,7 @@ func (c *Client) ChecksumFromFile(checksumFile string, src *url.URL) (*FileCheck
 	if err != nil {
 		return nil, err
 	}
-	defer os.Remove(tempfile)
+	defer func() { _ = os.Remove(tempfile) }()
 
 	c2 := &Client{
 		Ctx:              c.Ctx,
@@ -253,7 +257,7 @@ func (c *Client) ChecksumFromFile(checksumFile string, src *url.URL) (*FileCheck
 		return nil, fmt.Errorf(
 			"Error opening downloaded file: %s", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 	rd := bufio.NewReader(f)
 	for {
 		line, err := rd.ReadString('\n')

client.go

@@ -148,7 +148,7 @@ func (c *Client) Get() error {
 		if err != nil {
 			return err
 		}
-		defer tdcloser.Close()
+		defer func() { _ = tdcloser.Close() }()
 
 		realDst = dst
 		dst = td
@@ -210,7 +210,7 @@ func (c *Client) Get() error {
 			return fmt.Errorf(
 				"Error creating temporary directory for archive: %s", err)
 		}
-		defer os.RemoveAll(td)
+		defer func() { _ = os.RemoveAll(td) }()
 
 		// Swap the download directory to be our temporary path and
 		// store the old values.

client_option_progress_test.go

@@ -41,7 +41,7 @@ func TestGet_progress(t *testing.T) {
 
 	{ // dl without tracking
 		dst := tempTestFile(t)
-		defer os.RemoveAll(filepath.Dir(dst))
+		defer func() { _ = os.RemoveAll(filepath.Dir(dst)) }()
 		if err := GetFile(dst, s.URL+"/file?thig=this&that"); err != nil {
 			t.Fatalf("download failed: %v", err)
 		}
@@ -50,7 +50,7 @@ func TestGet_progress(t *testing.T) {
 	{ // tracking
 		p := &MockProgressTracking{}
 		dst := tempTestFile(t)
-		defer os.RemoveAll(filepath.Dir(dst))
+		defer func() { _ = os.RemoveAll(filepath.Dir(dst)) }()
 		if err := GetFile(dst, s.URL+"/file?thig=this&that", WithProgress(p)); err != nil {
 			t.Fatalf("download failed: %v", err)
 		}

cmd/go-getter/progress_tracking.go

@@ -49,7 +49,7 @@ func (cpb *ProgressBar) TrackProgress(src string, currentSize, totalSize int64,
 	ProgressBarConfig(newPb, filepath.Base(src))
 	if cpb.pool == nil {
 		cpb.pool = pb.NewPool()
-		cpb.pool.Start()
+		_ = cpb.pool.Start()
 	}
 	cpb.pool.Add(newPb)
 	reader := newPb.NewProxyReader(stream)
@@ -64,7 +64,7 @@ func (cpb *ProgressBar) TrackProgress(src string, currentSize, totalSize int64,
 			newPb.Finish()
 			cpb.pbs--
 			if cpb.pbs <= 0 {
-				cpb.pool.Stop()
+				_ = cpb.pool.Stop()
 				cpb.pool = nil
 			}
 			return nil

common.go

@@ -12,6 +12,6 @@ func tmpFile(dir, pattern string) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	f.Close()
+	_ = f.Close()
 	return f.Name(), nil
 }

decompress_bzip2.go

@@ -35,7 +35,7 @@ func (d *Bzip2Decompressor) Decompress(dst, src string, dir bool, umask os.FileM
 	if err != nil {
 		return err
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	// Bzip2 compression is second
 	bzipR := bzip2.NewReader(f)

decompress_gzip.go

@@ -35,14 +35,14 @@ func (d *GzipDecompressor) Decompress(dst, src string, dir bool, umask os.FileMo
 	if err != nil {
 		return err
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	// gzip compression is second
 	gzipR, err := gzip.NewReader(f)
 	if err != nil {
 		return err
 	}
-	defer gzipR.Close()
+	defer func() { _ = gzipR.Close() }()
 
 	// Copy it out
 	return copyReader(dst, gzipR, 0622, umask, d.FileSizeLimit)

decompress_tar.go

@@ -180,7 +180,7 @@ func (d *TarDecompressor) Decompress(dst, src string, dir bool, umask os.FileMod
 	if err != nil {
 		return err
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	return untar(f, dst, src, dir, umask, d.FileSizeLimit, d.FilesLimit)
 }

decompress_tar_test.go

@@ -146,7 +146,7 @@ func testDecompressorPermissions(t *testing.T, d Decompressor, input string, exp
 		t.Fatalf("err: %s", err)
 	}
 
-	defer os.RemoveAll(dst)
+	defer func() { _ = os.RemoveAll(dst) }()
 
 	for name, mode := range expected {
 		fi, err := os.Stat(filepath.Join(dst, name))