Skip to content

Conversation

@shleewhite
Copy link
Contributor

@shleewhite shleewhite commented Oct 25, 2025

📌 Summary

If merged, this PR updates the component integration tests to use the gts format.

The commits in the PR are organized as follows:

  • run the automation to convert most the tests to gjs (there were a couple that couldn't be automatically converted)
  • add any required devDeps to the showcase to type the tests
  • 1 commit per component where the tests are converted from gjs to gts

The changes include:

  • converting the tests to typescript, which ensures tests are using components correctly
  • switching from hbs wrapper around what the test renders, instead using <template> tags
  • using TrackedObject/Array instead of this.set()
  • moving away from using beforeEach for setting global values and instead defining things within the individual test context
  • I broke up the AdvancedTable index test file into several feature files that are sub-modules of advanced-table/index (this was just to make the file more understandable)
  • standardized how repeated components are rendered, using the precedent set by stepper and tabs (see advanced table, keyvalueinputs, table for examples)
  • added imports for sinon, codemirror in the showcase so tests can be typed correctly

REVIEWERS
Using the order of commits, you can click the link for the commit of the first component you are supposed to look at and then step through

If your section is looking good - please throw an approval on this PR, otherwise leave a comment.

🔗 External links

Jira ticket: HDS-XXX


👀 Component checklist

  • Percy was checked for any visual regression

💬 Please consider using conventional comments when reviewing this PR.

📋 PCI review checklist
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've worked with GRC to document the impact of any changes to security controls.
    Examples of changes to controls include access controls, encryption, logging, etc.
  • If applicable, I've worked with GRC to ensure compliance due to a significant change to the in-scope PCI environment.
    Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.

@vercel
Copy link

vercel bot commented Oct 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
hds-showcase Ready Ready Preview Nov 11, 2025 6:37pm
hds-website Ready Ready Preview Nov 11, 2025 6:37pm

@shleewhite shleewhite force-pushed the hds-5557/spike/convert-components-to-gts branch from 4ecc8f2 to 0837240 Compare October 30, 2025 20:55
@shleewhite shleewhite force-pushed the hds-5557/spike/convert-components-to-gts branch from 0837240 to 6055c04 Compare October 30, 2025 21:03
@shleewhite shleewhite force-pushed the hds-5557/spike/convert-components-to-gts branch from 6055c04 to db90285 Compare October 31, 2025 18:42
@shleewhite shleewhite force-pushed the hds-5557/spike/convert-components-to-gts branch from db90285 to 55ee921 Compare November 3, 2025 20:20
@shleewhite shleewhite force-pushed the hds-5557/spike/convert-components-to-gts branch from 55ee921 to b2fcd3e Compare November 3, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants