-
Notifications
You must be signed in to change notification settings - Fork 51
Showcase: convert integration tests to gts/gjs #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shleewhite
wants to merge
61
commits into
main
Choose a base branch
from
hds-5557/spike/convert-components-to-gts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16,482
−10,162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aklkv
reviewed
Oct 26, 2025
showcase/tests/integration/components/hds/accordion/index-test.gts
Outdated
Show resolved
Hide resolved
aklkv
reviewed
Oct 26, 2025
showcase/tests/integration/components/hds/accordion/index-test.gts
Outdated
Show resolved
Hide resolved
4ecc8f2 to
0837240
Compare
0837240 to
6055c04
Compare
6055c04 to
db90285
Compare
db90285 to
55ee921
Compare
55ee921 to
b2fcd3e
Compare
5767f60 to
04c85d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR updates the component integration tests to use the
gtsformat.The commits in the PR are organized as follows:
gjs(there were a couple that couldn't be automatically converted)gjstogtsThe changes include:
hbswrapper around what the test renders, instead using<template>tagsTrackedObject/Arrayinstead ofthis.set()beforeEachfor setting global values and instead defining things within the individual test contextadvanced-table/index(this was just to make the file more understandable)REVIEWERS
Using the order of commits, you can click the link for the commit of the first component you are supposed to look at and then step through
If your section is looking good - please throw an approval on this PR, otherwise leave a comment.
🔗 External links
Jira ticket: HDS-XXX
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.