From 147d221284fe174e5fe9acbe91bb15c1706eafb5 Mon Sep 17 00:00:00 2001 From: Zack Moore Date: Thu, 18 Sep 2025 15:40:50 -0400 Subject: [PATCH 1/3] removed unneeded deps --- packages/components/package.json | 7 +++---- pnpm-lock.yaml | 13 +++---------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/packages/components/package.json b/packages/components/package.json index 76c752d5cd9..9fbd783dd63 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -59,7 +59,6 @@ "codemirror-lang-hcl": "^0.0.0-beta.2", "decorator-transforms": "^2.3.0", "ember-a11y-refocus": "^4.1.4", - "ember-cli-sass": "^11.0.1", "ember-concurrency": "^4.0.4", "ember-element-helper": "^0.8.6", "ember-focus-trap": "^1.1.1", @@ -71,10 +70,9 @@ "ember-truth-helpers": "^4.0.3", "luxon": "^3.4.2", "prismjs": "^1.30.0", - "sass": "^1.83.0", - "tracked-built-ins": "^4.0.0", "tabbable": "^6.2.0", - "tippy.js": "^6.3.7" + "tippy.js": "^6.3.7", + "tracked-built-ins": "^4.0.0" }, "devDependencies": { "@babel/core": "^7.27.1", @@ -113,6 +111,7 @@ "rollup": "^4.39.0", "rollup-plugin-copy": "^3.5.0", "rollup-plugin-scss": "^4.0.1", + "sass": "^1.89.2", "stylelint": "^16.17.0", "stylelint-config-rational-order": "^0.1.2", "stylelint-config-standard-scss": "^14.0.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 841dc44c493..c32d6e53bbc 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -141,9 +141,6 @@ importers: ember-a11y-refocus: specifier: ^4.1.4 version: 4.1.4 - ember-cli-sass: - specifier: ^11.0.1 - version: 11.0.1 ember-concurrency: specifier: ^4.0.4 version: 4.0.4(@babel/core@7.28.0)(@glint/template@1.5.2) @@ -177,9 +174,6 @@ importers: prismjs: specifier: ^1.30.0 version: 1.30.0 - sass: - specifier: ^1.83.0 - version: 1.89.2 tabbable: specifier: ^6.2.0 version: 6.2.0 @@ -298,6 +292,9 @@ importers: rollup-plugin-scss: specifier: ^4.0.1 version: 4.0.1 + sass: + specifier: ^1.89.2 + version: 1.89.2 stylelint: specifier: ^16.17.0 version: 16.23.0(typescript@5.9.2) @@ -14201,7 +14198,6 @@ snapshots: codemirror-lang-hcl: 0.0.0-beta.2 decorator-transforms: 2.3.0(@babel/core@7.28.0) ember-a11y-refocus: 4.1.4 - ember-cli-sass: 11.0.1 ember-concurrency: 4.0.4(@babel/core@7.28.0)(@glint/template@1.5.2) ember-element-helper: 0.8.8 ember-focus-trap: 1.1.1(ember-source@6.5.0(@glimmer/component@1.1.2(@babel/core@7.28.0))(rsvp@4.8.5)) @@ -14213,7 +14209,6 @@ snapshots: ember-truth-helpers: 4.0.3(ember-source@6.5.0(@glimmer/component@1.1.2(@babel/core@7.28.0))(rsvp@4.8.5)) luxon: 3.7.1 prismjs: 1.30.0 - sass: 1.89.2 tabbable: 6.2.0 tippy.js: 6.3.7 tracked-built-ins: 4.0.0(@babel/core@7.28.0) @@ -14259,7 +14254,6 @@ snapshots: codemirror-lang-hcl: 0.0.0-beta.2 decorator-transforms: 2.3.0(@babel/core@7.28.0) ember-a11y-refocus: 4.1.4 - ember-cli-sass: 11.0.1 ember-concurrency: 4.0.4(@babel/core@7.28.0)(@glint/template@1.5.2) ember-element-helper: 0.8.8 ember-focus-trap: 1.1.1(ember-source@6.4.0(@glimmer/component@1.1.2(@babel/core@7.28.0))(rsvp@4.8.5)) @@ -14271,7 +14265,6 @@ snapshots: ember-truth-helpers: 4.0.3(ember-source@6.4.0(@glimmer/component@1.1.2(@babel/core@7.28.0))(rsvp@4.8.5)) luxon: 3.7.1 prismjs: 1.30.0 - sass: 1.89.2 tabbable: 6.2.0 tippy.js: 6.3.7 tracked-built-ins: 4.0.0(@babel/core@7.28.0) From 42a60aeaeeea0ed096125ede6ab11a234182e7cd Mon Sep 17 00:00:00 2001 From: Zack Moore Date: Wed, 24 Sep 2025 16:02:06 -0400 Subject: [PATCH 2/3] added changeset --- .changeset/full-showers-kiss.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/full-showers-kiss.md diff --git a/.changeset/full-showers-kiss.md b/.changeset/full-showers-kiss.md new file mode 100644 index 00000000000..799d2382714 --- /dev/null +++ b/.changeset/full-showers-kiss.md @@ -0,0 +1,6 @@ +--- +"@hashicorp/design-system-components": major +--- + +- Removed `sass` and `ember-cli-sass` as dependencies +- Added `sass` as a dev-dependency From 59e2d799060d256aad47ac8ba9eae753c1bfab4e Mon Sep 17 00:00:00 2001 From: Zack Moore Date: Tue, 30 Sep 2025 21:37:32 -0400 Subject: [PATCH 3/3] applying pr review suggestion --- .changeset/full-showers-kiss.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.changeset/full-showers-kiss.md b/.changeset/full-showers-kiss.md index 799d2382714..d5426a68e97 100644 --- a/.changeset/full-showers-kiss.md +++ b/.changeset/full-showers-kiss.md @@ -2,5 +2,4 @@ "@hashicorp/design-system-components": major --- -- Removed `sass` and `ember-cli-sass` as dependencies -- Added `sass` as a dev-dependency +- Removed `sass` and `ember-cli-sass` dependencies. Consumers using `sass` in their projects should make sure it's added as a direct dependency to their project.