From 6cef50b4b2ef986f37d3b487591fc8f7c2df8838 Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Wed, 25 May 2022 09:55:31 +0100 Subject: [PATCH 1/6] =?UTF-8?q?added=20controller=20for=20the=20=E2=80=9Cc?= =?UTF-8?q?omponents=E2=80=9D=20pages=20that=20takes=20care=20of=20handlin?= =?UTF-8?q?g=20`mock-state`=20attributes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../tests/dummy/app/controllers/components.js | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 packages/components/tests/dummy/app/controllers/components.js diff --git a/packages/components/tests/dummy/app/controllers/components.js b/packages/components/tests/dummy/app/controllers/components.js new file mode 100644 index 00000000000..d9521a943cf --- /dev/null +++ b/packages/components/tests/dummy/app/controllers/components.js @@ -0,0 +1,24 @@ +import Controller from '@ember/controller'; +import { scheduleOnce } from '@ember/runloop'; + +function replaceDummyStates() { + document.querySelectorAll('[mock-state-value]').forEach(function (element) { + let target; + if (element.attributes['mock-state-selector']) { + target = element.querySelector( + element.attributes['mock-state-selector'].value + ); + } else { + target = element; + } + const state = element.attributes['mock-state-value'].value; + target.classList.add(`mock-${state}`); + }); +} + +export default class ComponentsController extends Controller { + constructor() { + super(...arguments); + scheduleOnce('afterRender', this, replaceDummyStates); + } +} From 479aea4418e2648f46209b26fc031e2af101a645 Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Wed, 25 May 2022 09:57:58 +0100 Subject: [PATCH 2/6] updated `Dropdown` + `Button` dummy pages (and related components and CSS files) to use the new `mock-status` approach --- .../hds/dropdown/list-item/copy-item.hbs | 2 +- .../hds/dropdown/list-item/interactive.hbs | 5 +-- .../app/styles/components/button.scss | 38 +++++++++---------- .../app/styles/components/dropdown.scss | 20 +++++----- .../app/styles/mixins/_focus-ring.scss | 12 ++++-- .../dummy/app/templates/components/button.hbs | 10 ++++- .../app/templates/components/dropdown.hbs | 23 ++++++----- 7 files changed, 62 insertions(+), 48 deletions(-) diff --git a/packages/components/addon/components/hds/dropdown/list-item/copy-item.hbs b/packages/components/addon/components/hds/dropdown/list-item/copy-item.hbs index d1cc4f8ff8a..68a34c67c4c 100644 --- a/packages/components/addon/components/hds/dropdown/list-item/copy-item.hbs +++ b/packages/components/addon/components/hds/dropdown/list-item/copy-item.hbs @@ -6,7 +6,7 @@ {{/if}}