From cacf52f24834c3407ba06193a3dc19a1ab0a38fd Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Mon, 30 Jan 2023 21:13:39 +0000 Subject: [PATCH 1/3] used static values instead of `imgSrc` --- website/app/templates/head.hbs | 14 +++----------- website/config/environment.js | 1 - 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/website/app/templates/head.hbs b/website/app/templates/head.hbs index 24b1ac481e0..e27884d7046 100644 --- a/website/app/templates/head.hbs +++ b/website/app/templates/head.hbs @@ -38,19 +38,15 @@ We've made some small customizations to simplify this compared to the default te {{/if}} -{{#if this.model.imgSrc}} - -{{/if}} + {{! END OPENGRAPH }} {{! BEGIN TWITTER }} - -{{#if this.model.imgSrc}} - -{{/if}} + + {{#if this.model.title}} @@ -64,8 +60,4 @@ We've made some small customizations to simplify this compared to the default te {{/if}} -{{#if this.model.twitterUsername}} - -{{/if}} - {{! END TWITTER }} \ No newline at end of file diff --git a/website/config/environment.js b/website/config/environment.js index 5e2ac123917..512e13801ca 100644 --- a/website/config/environment.js +++ b/website/config/environment.js @@ -34,7 +34,6 @@ module.exports = function (environment) { siteName: 'Helios Design System', title: 'Helios Design System', url: 'https://helios.hashicorp.design', - imgSrc: 'https://helios.hashicorp.design/assets/logos/share-card.jpg', twitterUsername: '@HashiCorp', }, }; From 19a8bdcdcc701ee63d57c7667e218786bb93f597 Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Mon, 30 Jan 2023 21:29:19 +0000 Subject: [PATCH 2/3] need to disable linter on specific line or it will complain --- website/app/templates/head.hbs | 1 + 1 file changed, 1 insertion(+) diff --git a/website/app/templates/head.hbs b/website/app/templates/head.hbs index e27884d7046..9f006a11835 100644 --- a/website/app/templates/head.hbs +++ b/website/app/templates/head.hbs @@ -45,6 +45,7 @@ We've made some small customizations to simplify this compared to the default te {{! BEGIN TWITTER }} +{{! template-lint-disable no-forbidden-elements no-potential-path-strings }} From a35b7743f1e6c8bc5cfe16aafda5a6721737c768 Mon Sep 17 00:00:00 2001 From: Cristiano Rastelli Date: Mon, 30 Jan 2023 22:12:52 +0000 Subject: [PATCH 3/3] Update website/config/environment.js Co-authored-by: Melanie Sumner --- website/config/environment.js | 1 - 1 file changed, 1 deletion(-) diff --git a/website/config/environment.js b/website/config/environment.js index 512e13801ca..2cc0cbc3d24 100644 --- a/website/config/environment.js +++ b/website/config/environment.js @@ -34,7 +34,6 @@ module.exports = function (environment) { siteName: 'Helios Design System', title: 'Helios Design System', url: 'https://helios.hashicorp.design', - twitterUsername: '@HashiCorp', }, };