Remove deprecated HdsMenuPrimitive component (#3224)

Author: zamoore

.changeset/legal-swans-occur.md

@@ -0,0 +1,5 @@
+---
+"@hashicorp/design-system-components": major
+---
+
+Removed the deprecated `MenuPrimitive` component

packages/components/package.json

@@ -305,7 +305,6 @@
       "./components/hds/layout/grid/item.js": "./dist/_app_/components/hds/layout/grid/item.js",
       "./components/hds/link/inline.js": "./dist/_app_/components/hds/link/inline.js",
       "./components/hds/link/standalone.js": "./dist/_app_/components/hds/link/standalone.js",
-      "./components/hds/menu-primitive.js": "./dist/_app_/components/hds/menu-primitive.js",
       "./components/hds/modal/body.js": "./dist/_app_/components/hds/modal/body.js",
       "./components/hds/modal/footer.js": "./dist/_app_/components/hds/modal/footer.js",
       "./components/hds/modal/header.js": "./dist/_app_/components/hds/modal/header.js",

packages/components/src/components.ts

@@ -390,8 +390,5 @@ export { default as HdsDismissButton } from './components/hds/dismiss-button/ind
 // Interactive
 export { default as HdsInteractive } from './components/hds/interactive/index.ts';
 
-// MenuPrimitive
-export { default as HdsMenuPrimitive } from './components/hds/menu-primitive/index.ts';
-
 // PopoverPrimitive
 export { default as HdsPopoverPrimitive } from './components/hds/popover-primitive/index.ts';

packages/components/src/components/hds/dropdown/index.ts

@@ -15,7 +15,7 @@ import {
 } from './types.ts';
 
 import type { ComponentLike } from '@glint/template';
-import type { MenuPrimitiveSignature } from '../menu-primitive';
+import type { HdsPopoverPrimitiveSignature } from '../popover-primitive/index.ts';
 import type { HdsDropdownFooterSignature } from './footer';
 import type { HdsDropdownHeaderSignature } from './header';
 import type { HdsDropdownListItemCheckboxSignature } from './list-item/checkbox';
@@ -39,15 +39,16 @@ export const POSITIONS: HdsDropdownPositions[] = Object.values(
 );
 
 export interface HdsDropdownSignature {
-  Args: MenuPrimitiveSignature['Args'] & {
+  Args: {
     height?: string;
     isInline?: boolean;
-    isOpen?: boolean;
+    isOpen?: HdsPopoverPrimitiveSignature['Args']['isOpen'];
     listPosition?: HdsDropdownPositions;
     width?: string;
     enableCollisionDetection?: HdsAnchoredPositionOptions['enableCollisionDetection'];
     preserveContentInDom?: boolean;
     matchToggleWidth?: boolean;
+    onClose?: HdsPopoverPrimitiveSignature['Args']['onClose'];
   };
   Blocks: {
     default: [
@@ -69,7 +70,7 @@ export interface HdsDropdownSignature {
       },
     ];
   };
-  Element: MenuPrimitiveSignature['Element'];
+  Element: HTMLDivElement;
 }
 
 export default class HdsDropdown extends Component<HdsDropdownSignature> {

packages/components/src/components/hds/menu-primitive/index.hbs

@@ -39,7 +39,6 @@
 @use "../components/icon-tile";
 @use "../components/layout"; // multiple components
 @use "../components/link"; // multiple components
-@use "../components/menu-primitive";
 @use "../components/modal";
 @use "../components/page-header";
 @use "../components/pagination";

packages/components/src/components/hds/menu-primitive/index.ts

@@ -207,7 +207,7 @@ $hds-dropdown-toggle-border-radius: $hds-button-border-radius;
 
 // LIST
 // UL ELEMENT
-// GOES INSIDE HDS::MenuPrimitive's :content block
+// GOES INSIDE HDS::PopoverPrimitive's popover element
 
 .hds-dropdown__content {
   position: relative;

packages/components/src/styles/@hashicorp/design-system-components.scss

@@ -168,7 +168,6 @@ import type HdsLayoutGridComponent from './components/hds/layout/grid';
 import type HdsLayoutGridItemComponent from './components/hds/layout/grid/item';
 import type HdsLinkInlineComponent from './components/hds/link/inline';
 import type HdsLinkStandaloneComponent from './components/hds/link/standalone';
-import type HdsMenuPrimitiveComponent from './components/hds/menu-primitive';
 import type HdsModalBodyComponent from './components/hds/modal/body';
 import type HdsModalFooterComponent from './components/hds/modal/footer';
 import type HdsModalHeaderComponent from './components/hds/modal/header';
@@ -806,10 +805,6 @@ export default interface HdsComponentsRegistry {
   'Hds::Link::Standalone': typeof HdsLinkStandaloneComponent;
   'hds/link/standalone': typeof HdsLinkStandaloneComponent;
 
-  // MenuPrimitive
-  'Hds::MenuPrimitive': typeof HdsMenuPrimitiveComponent;
-  'hds/menu-primitive': typeof HdsMenuPrimitiveComponent;
-
   // Modal
   'Hds::Modal': typeof HdsModalComponent;
   'hds/modal': typeof HdsModalComponent;