Skip to content

Commit 04c85d5

Browse files
author
shleewhite
committed
fix: remove irrelevant comments, simplified checked attrs
1 parent 44b63aa commit 04c85d5

File tree

7 files changed

+21
-24
lines changed

7 files changed

+21
-24
lines changed

‎showcase/tests/integration/components/hds/flyout/index-test.gts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ module('Integration | Component | hds/flyout/index', function (hooks) {
391391
>Title</F.Header></HdsFlyout>
392392
</template>,
393393
);
394-
// the IDs are dynamically generated
394+
395395
const titleElement = find('.hds-flyout__title');
396396
assert
397397
.dom('dialog')

‎showcase/tests/integration/components/hds/form/checkbox/field-test.gts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ module('Integration | Component | hds/form/checkbox/field', function (hooks) {
4141
test('it renders the yielded contextual components', async function (assert) {
4242
await render(
4343
<template>
44-
<HdsFormCheckboxField checked="checked" as |F|>
44+
<HdsFormCheckboxField checked as |F|>
4545
<F.Label>This is the label</F.Label>
4646
<F.HelperText>This is the helper text</F.HelperText>
4747
<F.Error>This is the error</F.Error>

‎showcase/tests/integration/components/hds/form/checkbox/group-test.gts‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ module('Integration | Component | hds/form/checkbox/group', function (hooks) {
3333
<HdsFormCheckboxGroup as |G|>
3434
<G.Legend>This is the legend</G.Legend>
3535
<G.HelperText>This is the group helper text</G.HelperText>
36-
<G.CheckboxField checked="checked" @value="abc123" as |F|>
36+
<G.CheckboxField checked @value="abc123" as |F|>
3737
<F.Label>This is the control label</F.Label>
3838
<F.HelperText>This is the control helper text</F.HelperText>
3939
<F.Error>This is the control error</F.Error>
@@ -81,7 +81,7 @@ module('Integration | Component | hds/form/checkbox/group', function (hooks) {
8181
<HdsFormCheckboxGroup as |G|>
8282
<G.Legend>This is the legend</G.Legend>
8383
<G.HelperText>This is the group helper text</G.HelperText>
84-
<G.CheckboxField checked="checked" @value="abc123" as |F|>
84+
<G.CheckboxField checked @value="abc123" as |F|>
8585
<F.Label>This is the control label</F.Label>
8686
<F.HelperText>This is the control helper text</F.HelperText>
8787
<F.Error>This is the control error</F.Error>
@@ -90,7 +90,7 @@ module('Integration | Component | hds/form/checkbox/group', function (hooks) {
9090
</HdsFormCheckboxGroup>
9191
</template>,
9292
);
93-
// the IDs are dynamically generated
93+
9494
const groupHelperText = find('.hds-form-group__helper-text');
9595
const groupError = find('.hds-form-group__error');
9696
const fieldHelperText = find('.hds-form-field__helper-text');
@@ -112,7 +112,7 @@ module('Integration | Component | hds/form/checkbox/group', function (hooks) {
112112
<HdsFormCheckboxGroup as |G|>
113113
<G.Legend>This is the legend</G.Legend>
114114
<G.HelperText>This is the group helper text</G.HelperText>
115-
<G.CheckboxField checked="checked" @value="abc123" as |F|>
115+
<G.CheckboxField checked @value="abc123" as |F|>
116116
<F.Label>This is the control label</F.Label>
117117
<F.HelperText>This is the control helper text</F.HelperText>
118118
<F.Error>This is the control error</F.Error>
@@ -127,7 +127,6 @@ module('Integration | Component | hds/form/checkbox/group', function (hooks) {
127127
context.showErrors = true;
128128
await settled();
129129

130-
// the IDs are dynamically generated
131130
const groupHelperText = find('.hds-form-group__helper-text');
132131
const groupError = find('.hds-form-group__error');
133132
const fieldHelperText = find('.hds-form-field__helper-text');
@@ -172,7 +171,7 @@ module('Integration | Component | hds/form/checkbox/group', function (hooks) {
172171
<template>
173172
<HdsFormCheckboxGroup @isRequired={{true}} as |G|>
174173
<G.Legend>This is the legend</G.Legend>
175-
<G.CheckboxField checked="checked" @value="abc123" as |F|>
174+
<G.CheckboxField checked @value="abc123" as |F|>
176175
<F.Label>This is the control label</F.Label>
177176
</G.CheckboxField>
178177
</HdsFormCheckboxGroup>
@@ -187,7 +186,7 @@ module('Integration | Component | hds/form/checkbox/group', function (hooks) {
187186
<template>
188187
<HdsFormCheckboxGroup @isOptional={{true}} as |G|>
189188
<G.Legend>This is the legend</G.Legend>
190-
<G.CheckboxField checked="checked" @value="abc123" as |F|>
189+
<G.CheckboxField checked @value="abc123" as |F|>
191190
<F.Label>This is the control label</F.Label>
192191
</G.CheckboxField>
193192
</HdsFormCheckboxGroup>

‎showcase/tests/integration/components/hds/form/radio-card/group-test.gts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ module('Integration | Component | hds/form/radio-card/group', function (hooks) {
8989
</HdsFormRadioCardGroup>
9090
</template>,
9191
);
92-
// the IDs are dynamically generated
92+
9393
const groupHelperText = find('.hds-form-group__helper-text');
9494
const groupHelperTextId = groupHelperText?.id ?? '';
9595
const groupError = find('.hds-form-group__error');
@@ -121,7 +121,6 @@ module('Integration | Component | hds/form/radio-card/group', function (hooks) {
121121
context.showErrors = true;
122122
await settled();
123123

124-
// the IDs are dynamically generated
125124
const groupHelperText = find('.hds-form-group__helper-text');
126125
const groupHelperTextId = groupHelperText?.id ?? '';
127126
const groupError = find('.hds-form-group__error');

‎showcase/tests/integration/components/hds/form/radio/group-test.gts‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ module('Integration | Component | hds/form/radio/group', function (hooks) {
3939
<HdsFormRadioGroup as |G|>
4040
<G.Legend>This is the legend</G.Legend>
4141
<G.HelperText>This is the group helper text</G.HelperText>
42-
<G.RadioField checked="checked" @value="abc123" as |F|>
42+
<G.RadioField checked @value="abc123" as |F|>
4343
<F.Label>This is the control label</F.Label>
4444
<F.HelperText>This is the control helper text</F.HelperText>
4545
<F.Error>This is the control error</F.Error>
@@ -87,7 +87,7 @@ module('Integration | Component | hds/form/radio/group', function (hooks) {
8787
<HdsFormRadioGroup as |G|>
8888
<G.Legend>This is the legend</G.Legend>
8989
<G.HelperText>This is the group helper text</G.HelperText>
90-
<G.RadioField checked="checked" @value="abc123" as |F|>
90+
<G.RadioField checked @value="abc123" as |F|>
9191
<F.Label>This is the control label</F.Label>
9292
<F.HelperText>This is the control helper text</F.HelperText>
9393
<F.Error>This is the control error</F.Error>
@@ -96,7 +96,7 @@ module('Integration | Component | hds/form/radio/group', function (hooks) {
9696
</HdsFormRadioGroup>
9797
</template>,
9898
);
99-
// the IDs are dynamically generated
99+
100100
const groupHelperText = find('.hds-form-group__helper-text');
101101
const groupError = find('.hds-form-group__error');
102102
const fieldHelperText = find('.hds-form-field__helper-text');
@@ -120,7 +120,7 @@ module('Integration | Component | hds/form/radio/group', function (hooks) {
120120
<HdsFormRadioGroup as |G|>
121121
<G.Legend>This is the legend</G.Legend>
122122
<G.HelperText>This is the group helper text</G.HelperText>
123-
<G.RadioField checked="checked" @value="abc123" as |F|>
123+
<G.RadioField checked @value="abc123" as |F|>
124124
<F.Label>This is the control label</F.Label>
125125
<F.HelperText>This is the control helper text</F.HelperText>
126126
<F.Error>This is the control error</F.Error>
@@ -135,7 +135,6 @@ module('Integration | Component | hds/form/radio/group', function (hooks) {
135135
context.showErrors = true;
136136
await settled();
137137

138-
// the IDs are dynamically generated
139138
const groupHelperText = find('.hds-form-group__helper-text');
140139
const groupError = find('.hds-form-group__error');
141140
const fieldHelperText = find('.hds-form-field__helper-text');
@@ -210,7 +209,7 @@ module('Integration | Component | hds/form/radio/group', function (hooks) {
210209
<template>
211210
<HdsFormRadioGroup @isRequired={{true}} as |G|>
212211
<G.Legend>This is the legend</G.Legend>
213-
<G.RadioField checked="checked" @value="abc123" as |F|>
212+
<G.RadioField checked @value="abc123" as |F|>
214213
<F.Label>This is the control label</F.Label>
215214
</G.RadioField>
216215
</HdsFormRadioGroup>
@@ -225,7 +224,7 @@ module('Integration | Component | hds/form/radio/group', function (hooks) {
225224
<template>
226225
<HdsFormRadioGroup @isOptional={{true}} as |G|>
227226
<G.Legend>This is the legend</G.Legend>
228-
<G.RadioField checked="checked" @value="abc123" as |F|>
227+
<G.RadioField checked @value="abc123" as |F|>
229228
<F.Label>This is the control label</F.Label>
230229
</G.RadioField>
231230
</HdsFormRadioGroup>

‎showcase/tests/integration/components/hds/form/toggle/group-test.gts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ module('Integration | Component | hds/form/toggle/group', function (hooks) {
3232
<HdsFormToggleGroup as |G|>
3333
<G.Legend>This is the legend</G.Legend>
3434
<G.HelperText>This is the group helper text</G.HelperText>
35-
<G.ToggleField checked="checked" @value="abc123" as |F|>
35+
<G.ToggleField checked @value="abc123" as |F|>
3636
<F.Label>This is the control label</F.Label>
3737
<F.HelperText>This is the control helper text</F.HelperText>
3838
<F.Error>This is the control error</F.Error>
@@ -80,7 +80,7 @@ module('Integration | Component | hds/form/toggle/group', function (hooks) {
8080
<HdsFormToggleGroup as |G|>
8181
<G.Legend>This is the legend</G.Legend>
8282
<G.HelperText>This is the group helper text</G.HelperText>
83-
<G.ToggleField checked="checked" @value="abc123" as |F|>
83+
<G.ToggleField checked @value="abc123" as |F|>
8484
<F.Label>This is the control label</F.Label>
8585
<F.HelperText>This is the control helper text</F.HelperText>
8686
<F.Error>This is the control error</F.Error>
@@ -89,7 +89,7 @@ module('Integration | Component | hds/form/toggle/group', function (hooks) {
8989
</HdsFormToggleGroup>
9090
</template>,
9191
);
92-
// the IDs are dynamically generated
92+
9393
const groupHelperText = find('.hds-form-group__helper-text');
9494
const groupError = find('.hds-form-group__error');
9595
const fieldHelperText = find('.hds-form-field__helper-text');
@@ -110,7 +110,7 @@ module('Integration | Component | hds/form/toggle/group', function (hooks) {
110110
<template>
111111
<HdsFormToggleGroup @isRequired={{true}} as |G|>
112112
<G.Legend>This is the legend</G.Legend>
113-
<G.ToggleField checked="checked" @value="abc123" as |F|>
113+
<G.ToggleField checked @value="abc123" as |F|>
114114
<F.Label>This is the control label</F.Label>
115115
</G.ToggleField>
116116
</HdsFormToggleGroup>
@@ -125,7 +125,7 @@ module('Integration | Component | hds/form/toggle/group', function (hooks) {
125125
<template>
126126
<HdsFormToggleGroup @isOptional={{true}} as |G|>
127127
<G.Legend>This is the legend</G.Legend>
128-
<G.ToggleField checked="checked" @value="abc123" as |F|>
128+
<G.ToggleField checked @value="abc123" as |F|>
129129
<F.Label>This is the control label</F.Label>
130130
</G.ToggleField>
131131
</HdsFormToggleGroup>

‎showcase/tests/integration/components/hds/modal/index-test.gts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ module('Integration | Component | hds/modal/index', function (hooks) {
417417
</HdsModal>
418418
</template>,
419419
);
420-
// the IDs are dynamically generated
420+
421421
const titleElement = find('.hds-modal__title');
422422
assert
423423
.dom('dialog')

0 commit comments

Comments
 (0)