From 97dc4547d4f117ec407b04fc74bceafe7ea43be0 Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Mon, 25 Sep 2023 10:19:39 -0400 Subject: [PATCH 1/3] Dump response body on fail --- agent/metrics_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/agent/metrics_test.go b/agent/metrics_test.go index fd4f9f8d2e1..eae72a75b46 100644 --- a/agent/metrics_test.go +++ b/agent/metrics_test.go @@ -491,7 +491,7 @@ func TestHTTPHandlers_AgentMetrics_WAL_Prometheus(t *testing.T) { if t.Failed() { t.Log("--- Failed output START ---") t.Log(out) - t.Log("--- Failed output END ---") + t.Log("--- Failed output END -test--") } }() require.Contains(t, out, "agent_5_raft_wal_head_truncations") From 4dcd177725a622d70ee7cbb3ff1d91b3d5089223 Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Mon, 25 Sep 2023 14:59:04 -0400 Subject: [PATCH 2/3] Remove p flag --- .github/workflows/reusable-unit-split.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/reusable-unit-split.yml b/.github/workflows/reusable-unit-split.yml index 0ec639c28ff..29c341998dd 100644 --- a/.github/workflows/reusable-unit-split.yml +++ b/.github/workflows/reusable-unit-split.yml @@ -129,8 +129,7 @@ jobs: --rerun-fails-report=/tmp/gotestsum-rerun-fails \ --packages="$PACKAGE_NAMES" \ --junitfile ${{env.TEST_RESULTS}}/gotestsum-report.xml -- \ - -tags="${{env.GOTAGS}}" -p 2 \ - ${GO_TEST_FLAGS-} \ + -tags="${{env.GOTAGS}}" \ -cover -coverprofile=coverage.txt # NOTE: ENT specific step as we store secrets in Vault. From c25f035d5f9dc4d386bc3ca4806895ed1d8cbf90 Mon Sep 17 00:00:00 2001 From: "Chris S. Kim" Date: Mon, 25 Sep 2023 14:59:35 -0400 Subject: [PATCH 3/3] Revert test --- agent/metrics_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/agent/metrics_test.go b/agent/metrics_test.go index eae72a75b46..fd4f9f8d2e1 100644 --- a/agent/metrics_test.go +++ b/agent/metrics_test.go @@ -491,7 +491,7 @@ func TestHTTPHandlers_AgentMetrics_WAL_Prometheus(t *testing.T) { if t.Failed() { t.Log("--- Failed output START ---") t.Log(out) - t.Log("--- Failed output END -test--") + t.Log("--- Failed output END ---") } }() require.Contains(t, out, "agent_5_raft_wal_head_truncations")