agent: blocking central config RPCs iterations should not interfere with each other #6316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response variable from the ResolveServiceConfig RPC is mutated while various state store operations are performed.
This means that when a blocking query necessitates re-executing the body of the query (due to something like deleting
proxy-defaults/global
) some information from the previous speculative query bleeds over by way of the shared response variable.The easy fix here is to reset the state of the response variable at the stop of the query.