Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: blocking central config RPCs iterations should not interfere with each other #6316

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Aug 13, 2019

The response variable from the ResolveServiceConfig RPC is mutated while various state store operations are performed.

This means that when a blocking query necessitates re-executing the body of the query (due to something like deleting proxy-defaults/global) some information from the previous speculative query bleeds over by way of the shared response variable.

The easy fix here is to reset the state of the response variable at the stop of the query.

@rboyer rboyer added this to the 1.6.0-final milestone Aug 13, 2019
@rboyer rboyer requested a review from a team August 13, 2019 21:45
@rboyer rboyer self-assigned this Aug 13, 2019
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants