From cd0b72b955e4ef4c891196de69054821b56925ec Mon Sep 17 00:00:00 2001 From: NiniOak Date: Wed, 20 Mar 2024 22:07:17 +0000 Subject: [PATCH 1/3] backport of commit 6e6f4c946ac4e0658bd8443bec99283ede4a958b --- acceptance/framework/helpers/helpers.go | 8 ++++++-- acceptance/tests/api-gateway/api_gateway_test.go | 3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/acceptance/framework/helpers/helpers.go b/acceptance/framework/helpers/helpers.go index 3c41957f9e..e665eb3a34 100644 --- a/acceptance/framework/helpers/helpers.go +++ b/acceptance/framework/helpers/helpers.go @@ -223,9 +223,13 @@ func RunCommand(t testutil.TestingTB, options *k8s.KubectlOptions, command Comma select { case res := <-resultCh: - return res.output, res.err + if res.err != nil { + resErr := fmt.Errorf("error: %v\nOutput: %s", res.err, res.output) + return "", resErr + } + return res.output, nil // Sometimes this func runs for too long handle timeout if needed. - case <-time.After(320 * time.Second): + case <-time.After(400 * time.Second): GetCRDRemoveFinalizers(t, options) logger.Logf(t, "RunCommand timed out") return "", nil diff --git a/acceptance/tests/api-gateway/api_gateway_test.go b/acceptance/tests/api-gateway/api_gateway_test.go index bbbaa569d4..13cf517382 100644 --- a/acceptance/tests/api-gateway/api_gateway_test.go +++ b/acceptance/tests/api-gateway/api_gateway_test.go @@ -107,11 +107,14 @@ func TestAPIGateway_Basic(t *testing.T) { logger.Log(t, "creating static-client pod") k8s.DeployKustomize(t, ctx.KubectlOptions(t), cfg.NoCleanupOnFailure, cfg.NoCleanup, cfg.DebugDirectory, "../fixtures/bases/static-client") + k8s.RunKubectl(t, ctx.KubectlOptions(t), "wait", "--for=condition=available", "--timeout=5m", fmt.Sprintf("deploy/%s", "static-server")) + logger.Log(t, "patching route to target http server") k8s.RunKubectl(t, ctx.KubectlOptions(t), "patch", "httproute", "http-route", "-p", `{"spec":{"rules":[{"backendRefs":[{"name":"static-server","port":80}]}]}}`, "--type=merge") logger.Log(t, "creating target tcp server") k8s.DeployKustomize(t, ctx.KubectlOptions(t), cfg.NoCleanupOnFailure, cfg.NoCleanup, cfg.DebugDirectory, "../fixtures/bases/static-server-tcp") + k8s.RunKubectl(t, ctx.KubectlOptions(t), "wait", "--for=condition=available", "--timeout=5m", fmt.Sprintf("deploy/%s", "static-server-tcp")) logger.Log(t, "creating tcp-route") k8s.RunKubectl(t, ctx.KubectlOptions(t), "apply", "-f", "../fixtures/cases/api-gateways/tcproute/route.yaml") From 9efd9d9a4ccc0649c617df6854422239d8e6afbb Mon Sep 17 00:00:00 2001 From: NiniOak Date: Wed, 20 Mar 2024 22:15:35 +0000 Subject: [PATCH 2/3] backport of commit b3e66a8a0473b3321c6271a26c94871debb00967 --- acceptance/framework/helpers/helpers.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acceptance/framework/helpers/helpers.go b/acceptance/framework/helpers/helpers.go index e665eb3a34..46e1ae6f82 100644 --- a/acceptance/framework/helpers/helpers.go +++ b/acceptance/framework/helpers/helpers.go @@ -229,7 +229,7 @@ func RunCommand(t testutil.TestingTB, options *k8s.KubectlOptions, command Comma } return res.output, nil // Sometimes this func runs for too long handle timeout if needed. - case <-time.After(400 * time.Second): + case <-time.After(320 * time.Second): GetCRDRemoveFinalizers(t, options) logger.Logf(t, "RunCommand timed out") return "", nil From 89d33fc1180e0679de56f2fde1af30113c3ac360 Mon Sep 17 00:00:00 2001 From: NiniOak Date: Wed, 20 Mar 2024 22:55:30 +0000 Subject: [PATCH 3/3] backport of commit 2c8bc07e7d6c96324691ac1f121ed8ae400ffabf --- acceptance/framework/helpers/helpers.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/acceptance/framework/helpers/helpers.go b/acceptance/framework/helpers/helpers.go index 46e1ae6f82..0871532426 100644 --- a/acceptance/framework/helpers/helpers.go +++ b/acceptance/framework/helpers/helpers.go @@ -224,10 +224,9 @@ func RunCommand(t testutil.TestingTB, options *k8s.KubectlOptions, command Comma select { case res := <-resultCh: if res.err != nil { - resErr := fmt.Errorf("error: %v\nOutput: %s", res.err, res.output) - return "", resErr + logger.Logf(t, "Output: %v.", res.output) } - return res.output, nil + return res.output, res.err // Sometimes this func runs for too long handle timeout if needed. case <-time.After(320 * time.Second): GetCRDRemoveFinalizers(t, options)