Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump expo version #2392

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Jul 9, 2024

Description:

Bumps expo version in package.json to latest possible version.

Related issue(s): #2361

Fixes #2361

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ivaylonikolov7 ivaylonikolov7 force-pushed the chore/bump-expo-version branch 2 times, most recently from 6fd9cdc to 58ed9ce Compare July 9, 2024 08:24
@ivaylonikolov7 ivaylonikolov7 marked this pull request as ready for review July 9, 2024 08:59
@ivaylonikolov7 ivaylonikolov7 requested review from a team as code owners July 9, 2024 08:59
@ivaylonikolov7 ivaylonikolov7 self-assigned this Jul 9, 2024
@svetoslav-nikol0v svetoslav-nikol0v requested review from agadzhalov and svetoslav-nikol0v and removed request for rwalworth July 9, 2024 11:24
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubixvi
Copy link

rubixvi commented Jul 11, 2024

Not sure if this will fix the issue; when creating a server or sending a transaction, the SDK returns a Base64 when invoking execute.(client).

const newAccountTransaction = await new AccountCreateTransaction()
  .setKey(newAccountPublicKey)
  .setInitialBalance(0)
  .freezeWith(client);

  const signedTransaction = await newAccountTransaction.sign(newPrivateKey);
  const response = await signedTransaction.execute(client); <--- error is from here.
  
  Ran it with shims, works on web but once it's on mobile it no longer works.
  The way I have it running now is to setup an express server to run an API directly to the server and execute the script which works flawlessly.  

@ivaylonikolov7
Copy link
Contributor Author

Hello, @rubixvi. I'd like to ask you additional information if you dont mind. Here's a couple of questions that are gonna help me solve your issues:

  • What's the version of the SDK that you use
  • Which network do you use - Is it testnet, local-node, previewnet?
  • Most importantly - whats the error that executing the transaction throws?
  • If you can please send me the whole snippet including initializing the client, setting up the operator, the import files in your file too would be nice to see. The more info you give us, the faster it will be to fix your problem.

ivaylonikolov7 and others added 2 commits July 23, 2024 13:35
Signed-off-by: Ivaylo Nikolov <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Copy link

sonarcloud bot commented Jul 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo Version ([email protected])
3 participants