Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better inputs design #39

Closed
NoamGaash opened this issue Sep 11, 2023 · 5 comments
Closed

Better inputs design #39

NoamGaash opened this issue Sep 11, 2023 · 5 comments
Assignees
@aviv1620
Labels
CSS related to the design, without affecting business logic good first issue Good for newcomers

Comments

@NoamGaash
Copy link
Member

  • fix direction (text direction should be RTL, alignment to right, buttons should be to the left)
  • fix placement - align all inputs to the same column

image
@NoamGaash NoamGaash added good first issue Good for newcomers CSS related to the design, without affecting business logic labels Sep 11, 2023
@aviv1620
Copy link
Collaborator

aviv1620 commented Sep 13, 2023 •
edited
Loading

Assignee

@aviv1620 aviv1620 mentioned this issue Sep 18, 2023
Merged
@aviv1620
Copy link
Collaborator

Untitled
I fix the direction. Tomorrow I will fix the placement in another PR.
the WARNING Failed to parse source it in create-react-app.
have PR in create-react-app that still open facebook/create-react-app#11752
The last mention came last week.

@NoamGaash
Copy link
Member Author

@aviv1620 thanks! I'll take a look
anyway, specifically CRA is no longer maintained (see their commit history)

@aviv1620 aviv1620 mentioned this issue Sep 20, 2023
Merged
@aviv1620
Copy link
Collaborator

I use MUI grid v2 for the layout.
https://mui.com/material-ui/react-grid2/

look much better.
on desktop and also on mobile(bonus)
desktop
mobile

@NoamGaash
Copy link
Member Author

I think it's much better now.
Feel free to re-open this issue with concrete examples of how can we improve

@ArkadiK94 ArkadiK94 mentioned this issue Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aviv1620 aviv1620

Labels
CSS related to the design, without affecting business logic good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoamGaash @aviv1620