Ensure strip_html filter uses same regex as Ruby Liquid. Fixes #68 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this handle tags on different lines? The regex removes this: <style type="text/css">.test-one-line {display: none;}</style>But not this <style type="text/css">
.test-one-line {display: none;}
</style>I was able to workaround this issue by using |
aciccarello
added a commit
to aciccarello/ciccarello.me
that referenced
this pull request
Feb 27, 2023
harttle
added a commit
that referenced
this pull request
Mar 2, 2023
|
@aciccarello please try v10.6.1 |
|
I've confirmed this is working as expected. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in #68. I hope my tests are correct; I used
"for my attribute test given the advice I found here.