Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

linux: set playback rate and set volume not working #18

Open
esiqveland opened this issue Jan 6, 2022 · 0 comments · Fixed by #19
Open

linux: set playback rate and set volume not working #18

esiqveland opened this issue Jan 6, 2022 · 0 comments · Fixed by #19

Comments

@esiqveland
Copy link
Contributor

esiqveland commented Jan 6, 2022

When running the example I noticed only volume set to max (1.0) works. everything < 1.0 gets used as zero volume. Noticed the same for playback rate.

I tracked it down to std::to_string being locale aware, and in my locale it prints a float with comma , as the decimal point, breaking the volume setting.

https://github.com/harmonoid/libwinmedia/blob/master/linux/player.hpp#L410

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants