Skip to content

Feedback about edit modal UX #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks
lgo opened this issue Jan 10, 2025 · 1 comment
Open
6 tasks

Feedback about edit modal UX #794

lgo opened this issue Jan 10, 2025 · 1 comment
Assignees

Comments

@lgo
Copy link

lgo commented Jan 10, 2025

Just reporting some UX issues around the modals to edit things (Edit Repair Record, etc.)

  • Because the cofirmations are always "Edit Record", the size varies which is a bit of a jarring experience and is hard to mentally go "oh, that's where it's going to be". I missed quite a few times while doing lots of edits between various types to backfill data.
  • I also had some double-takes because the prompt was "Edit" rather than something like "Confirm" or "Save" - I'm already editing, so why would I need to "Edit" again?
  • When editing, there's no confirmation prompt to discard edits prompt if you click out of the modal with unsaved edits. While it does track unsaved edits (hooray!), I found I was sometimes trying to figure out which item I was editing again (after missing the confirm, noted above) and have to find it again.
  • On "Edit Supply Record" it was not clear whether the "Cost" is "Unit Cost" or "Total Cost" until I clicked the little "+" on quantity and it seems like unit costs are automatically calculated. It may be better to name it more specifically upfront
  • Entering a value into a cost with a $, the entire number is dropped. This may be common when copy-pasting values over. It would be great to discard the $ (or potentially all non-digit/.?) to make that a little more usable in some situations
  • Similarly, I found whitespaces are not ignored/stripped on various number fields (e.g. Supply Record's quantity and cost)

Nonetheless, this is an awesome app and I'm happy to replace spreadsheets with something I can convince my partner to use!

@lgo lgo changed the title Text on modals for confirming a save are jarring Feedback about edit modal UX Jan 10, 2025
@hargata hargata self-assigned this Jan 10, 2025
@tigattack
Copy link

tigattack commented Feb 12, 2025

Similarly, I think the notes input field would appreciate some tweaks. I'm a bit of an overzealous note-taker, so my notes fields tend to ed end pretty long. This results in the following issues:

  • When in markdown viewing mode, the field doesn't automatically expand to the size of the contents. I'd like if it did this, whether within the bounds of the modal-body div or even by auto-expanding the vertical height of the modal-body div to fit the full contents of the notes field in view, like when you expand the field in edit mode with the handle on the bottom right.
    It's nice that the field size is remembered when switching between edit and view modes, but having to switch to edit, expand the field, and switch back to view isn't a very nice UX.
  • When expanding the field in edit mode using the handle on the bottom right, only vertical expansion is possible. I'd like if I could also expand horizontally to make for easier editing of long lines and improved readability when editing markdown syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants